vikunja/vikunja
8
54
Fork 94
Code Issues 101 Pull Requests 31 Packages Releases 37 Activity

Vue 3 Migration issues #1849

New Issue
Closed
opened 2021-10-17 20:24:12 +00:00 by konrad · 11 comments
konrad commented 2021-10-17 20:24:12 +00:00
Owner
Copy Link

Follow-up task from #815 to collect all post-migration issues.

TODOs

  • After setting a label color, it gets reset to black
  • Opening the quick add menu yields Message compilation error: Invalid linked format but seems to work fine otherwise
  • Loading state does not work when loading tasks on a list
  • The edit task pane in task list looks broken
  • [Vue Router warn]: Absolute path "/tasks/:id" should have the exact same param named "listId" as its parent "/lists/:listId/list". and similar for other routes
  • Direct store manipulation in task.js vuex module - there's FIXMEs in the relevant places
  • Invalid prop: type check failed for prop "currentPage". Expected Number with value NaN, got Undefined when accessing list views - PR: vikunja/frontend#1002
Follow-up task from #815 to collect all post-migration issues. ### TODOs * [ ] After setting a label color, it gets reset to black * [x] Opening the quick add menu yields `Message compilation error: Invalid linked format` but seems to work fine otherwise * [x] Loading state does not work when loading tasks on a list * [x] The edit task pane in task list looks broken * [ ] `[Vue Router warn]: Absolute path "/tasks/:id" should have the exact same param named "listId" as its parent "/lists/:listId/list".` and similar for other routes * [ ] Direct store manipulation in task.js vuex module - there's `FIXME`s in the relevant places * [x] `Invalid prop: type check failed for prop "currentPage". Expected Number with value NaN, got Undefined` when accessing list views - PR: https://kolaente.dev/vikunja/frontend/pulls/1002
konrad self-assigned this 2021-10-17 20:24:12 +00:00
dpschen was assigned by konrad 2021-10-17 20:24:12 +00:00
dpschen commented 2021-10-17 21:11:22 +00:00
Member
Copy Link

Opening the quick add menu yields Message compilation error: Invalid linked format but seems to work fine otherwise

This is because of all the @s in the translation (see screenshot)

> Opening the quick add menu yields Message compilation error: Invalid linked format but seems to work fine otherwise This is because of all the `@`s in the translation (see screenshot)
Screenshot 2021-10-17 at 23.11.15.png
211 KiB
Screenshot 2021-10-17 at 23.11.15.png
dpschen commented 2021-10-25 14:45:57 +00:00
Member
Copy Link

[Vue Router warn]: Absolute path "/tasks/:id" should have the exact same param named "listId" as its parent "/lists/:listId/list". and similar for other routes

This should be solved with vikunja/frontend#816 (not yet ready).

`[Vue Router warn]: Absolute path "/tasks/:id" should have the exact same param named "listId" as its parent "/lists/:listId/list". and similar for other routes` This should be solved with https://kolaente.dev/vikunja/frontend/pulls/816 (not yet ready).
👍 1
dpschen commented 2021-11-26 13:24:56 +00:00
Member
Copy Link

@konrad: where was this fixed:

The edit task pane in task list looks broken

@konrad: where was this fixed: > The edit task pane in task list looks broken
konrad commented 2021-11-26 13:26:38 +00:00
Author
Owner
Copy Link

@dpschen very good question.

@dpschen very good question.
dpschen commented 2021-11-26 13:29:57 +00:00
Member
Copy Link

Shall I remove that tick?

Shall I remove that tick?
konrad commented 2021-11-26 13:34:26 +00:00
Author
Owner
Copy Link

I mean it's not broken anymore (at least as far as I was able to see it?). Just don't remember where it was fixed 😃

I mean it's not broken anymore (at least as far as I was able to see it?). Just don't remember where it was fixed 😃
dpschen commented 2021-11-26 13:38:34 +00:00
Member
Copy Link

Ahh I think I thought it meant the edit pane in the gantt view:

(still don't know how to reference uploaded images here)

Ahh I think I thought it meant the edit pane in the gantt view: (still don't know how to reference uploaded images here)
try.vikunja.io_lists_1_gantt.png
299 KiB
try.vikunja.io_lists_1_gantt.png
konrad commented 2021-11-26 19:59:16 +00:00
Author
Owner
Copy Link

I think that's something that affects the sidebar in the task list view as well?

I think that's something that affects the sidebar in the task list view as well?
dpschen commented 2021-11-26 20:18:46 +00:00
Member
Copy Link

Possible!

Possible!
xeruf commented 2022-07-13 20:30:32 +00:00
Copy Link

Are these resolved?

Are these resolved?
konrad commented 2022-07-13 20:49:07 +00:00
Author
Owner
Copy Link

So far, I think so yes. We'll open separate tasks for new ones.

So far, I think so yes. We'll open separate tasks for new ones.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
moved-to-github
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees konrad dpschen
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#1849
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?