refactor: remove default filter from frontend, apply by default to new list views instead #2240

waza-ari · 2024-03-29T16:25:51Z

waza-ari commented

2024-03-29 16:25:51 +00:00

Fixes #2234

waza-ari added 1 commit 2024-03-29 16:25:54 +00:00

continuous-integration/drone/pr Build is passing Details

a64eb0ffcf refactor: remove default filter from frontend, apply by default to new list views instead

frederick commented

2024-03-29 16:36:24 +00:00

Hi waza-ari!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2240-2234-remove-default-filter--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi waza-ari! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2240-2234-remove-default-filter--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.

konrad requested changes 2024-03-29 17:22:39 +00:00

Dismissed

pkg/migration/20240329170952.go Outdated

						
				@ -0,0 +48,4 @@

							for _, view := range projectViews {

								if view.ViewKind == 0 && view.Filter == "" {

									view.Filter = "done = false"

									_, err := tx.ID(view.ID).Update(view)

konrad commented

2024-03-29 17:22:18 +00:00

Please do this in one query instead of a loop, something like this:

tx.Where("view_kind = ? AND filter = ?", 0, "").Cols("filter").Update(&projectView20240329170952{Filter: ""})

Please do this in one query instead of a loop, something like this: ``` tx.Where("view_kind = ? AND filter = ?", 0, "").Cols("filter").Update(&projectView20240329170952{Filter: ""}) ```

waza-ari commented

2024-03-29 17:42:25 +00:00

Good point, that's much simpler :)

waza-ari marked this conversation as resolved

waza-ari added 1 commit 2024-03-29 17:39:55 +00:00

continuous-integration/drone/pr Build is failing Details

9efc5e22e1 refactor: simplify migration to single query

konrad commented

2024-03-29 18:09:51 +00:00

Now lint and test fails :/

😆 1

waza-ari added 1 commit 2024-03-29 18:51:10 +00:00