refactor: remove default filter from frontend, apply by default to new list views instead #2240
No reviewers
Labels
No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/vikunja#2240
Loading…
Reference in New Issue
No description provided.
Delete Branch "waza-ari/vikunja:2234-remove-default-filter"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #2234
Hi waza-ari!
Thank you for creating a PR!
I've deployed the frontend changes of this PR on a preview environment under this URL: https://2240-2234-remove-default-filter--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.
This preview does not contain any changes made to the api, only the frontend.
Have a nice day!
@ -0,0 +48,4 @@
for _, view := range projectViews {
if view.ViewKind == 0 && view.Filter == "" {
view.Filter = "done = false"
_, err := tx.ID(view.ID).Update(view)
Please do this in one query instead of a loop, something like this:
Good point, that's much simpler :)
Now lint and test fails :/
55a425c4d7
to7cc42e55e2