vikunja/vikunja
5
48
Fork 86
Code Issues 133 Pull Requests 33 Packages Releases 37 Activity

Enable a list to be moved across namespaces #1096

Merged
konrad merged 7 commits from shilch/api:feature/move-list into main 2022-01-23 12:59:44 +00:00
Conversation 1 Commits 7 Files Changed 7 +89 -4
shilch commented 2022-01-22 22:14:20 +00:00
Collaborator
Copy Link

Description

Allows a list to be moved across namespaces by accepting a different namespace_id when updating a list. This only changes the backend code; the feature is not yet implemented as a frontend action.
The written unit tests pass but I haven't actually tried the API call yet (thus WIP).

Checklist

  • I added or improved tests
  • I added or improved docs for my feature
    • Swagger (including mage do-the-swag)
    • Error codes
    • New config options (including adding them to config.yml.saml and running mage generate-docs)
# Description Allows a list to be moved across namespaces by accepting a different `namespace_id` when updating a list. This only changes the backend code; the feature is not yet implemented as a frontend action. The written unit tests pass but I haven't actually tried the API call yet (thus WIP). # Checklist * [x] I added or improved tests * [x] I added or improved docs for my feature * [x] Swagger (including `mage do-the-swag`) * [x] Error codes * [x] New config options (including adding them to `config.yml.saml` and running `mage generate-docs`)
shilch added 6 commits 2022-01-22 22:14:22 +00:00 
Running mage test:coverage fails due to a missing cover.out coverprofile.
Since test:coverage depends on test:unit, we let test:unit generate the cover.out file.
Update swagger docs
All checks were successful
continuous-integration/drone/pr Build is passing
Details
eaabad5861
konrad requested changes 2022-01-23 11:12:29 +00:00
konrad left a comment
Owner
Copy Link

Very nice, thanks a lot!

Just some small nits, looks fine overall.

Very nice, thanks a lot! Just some small nits, looks fine overall.
pkg/cmd/web.go Outdated
@ -90,6 +90,7 @@ var webCmd = &cobra.Command{
e.Logger.Fatal(err)
}
}
log.Infof("Server is running on %s", config.ServiceInterface.GetString())
konrad commented 2022-01-23 11:10:24 +00:00
Owner
Copy Link

Echo already shows a message like this when the server is started - I feel like this would double it. Also it does not take into account if the server is listening on a socket instead. I would prefer to remove this.

Echo already shows a message like this when the server is started - I feel like this would double it. Also it does not take into account if the server is listening on a socket instead. I would prefer to remove this.
shilch commented 2022-01-23 12:04:05 +00:00
Author
Collaborator
Copy Link

Reverted

Reverted
konrad marked this conversation as resolved
pkg/swagger/docs.go
@ -9216,3 +9216,3 @@
func init() {
swag.Register(swag.Name, &s{})
swag.Register("swagger", &s{})
konrad commented 2022-01-23 11:12:06 +00:00
Owner
Copy Link

Not quite sure where this is coming from, but probably fine to have. What swag version do you have installed?

Not quite sure where this is coming from, but probably fine to have. What swag version do you have installed?
shilch commented 2022-01-23 11:14:58 +00:00
Author
Collaborator
Copy Link
swag --version
swag version v1.7.8

Which is the latest one.

``` swag --version swag version v1.7.8 ``` Which is [the latest one](https://github.com/swaggo/swag/releases/tag/v1.7.8).
konrad commented 2022-01-23 11:18:43 +00:00
Owner
Copy Link

I think it should be fine then.

I think it should be fine then.
konrad marked this conversation as resolved
konrad commented 2022-01-23 11:17:53 +00:00
Owner
Copy Link

Just checked with curl and it works without issues.

Just checked with curl and it works without issues.
shilch changed title from WIP: Enable a list to be moved across namespaces to Enable a list to be moved across namespaces 2022-01-23 12:02:12 +00:00
shilch added 1 commit 2022-01-23 12:03:38 +00:00
Revert "Log server listening endpoint on startup"
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ce3f3ed687 
This reverts commit a38faeabc39f7efec9bc05af15378b54af4f772e.
konrad approved these changes 2022-01-23 12:04:31 +00:00
konrad left a comment
Owner
Copy Link

Looks good, will merge once the pipeline succeeds.

Looks good, will merge once the pipeline succeeds.
konrad merged commit f7a06e4644 into main 2022-01-23 12:59:44 +00:00
konrad deleted branch feature/move-list 2022-01-23 12:59:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#1096
No description provided.
Delete Branch "shilch/api:feature/move-list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?