Enable a list to be moved across namespaces #1096
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "shilch/api:feature/move-list"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
Allows a list to be moved across namespaces by accepting a different
namespace_id
when updating a list. This only changes the backend code; the feature is not yet implemented as a frontend action.The written unit tests pass but I haven't actually tried the API call yet (thus WIP).
Checklist
mage do-the-swag
)config.yml.saml
and runningmage generate-docs
)Very nice, thanks a lot!
Just some small nits, looks fine overall.
@ -90,6 +90,7 @@ var webCmd = &cobra.Command{
e.Logger.Fatal(err)
}
}
log.Infof("Server is running on %s", config.ServiceInterface.GetString())
Echo already shows a message like this when the server is started - I feel like this would double it. Also it does not take into account if the server is listening on a socket instead. I would prefer to remove this.
Reverted
@ -9216,3 +9216,3 @@
func init() {
swag.Register(swag.Name, &s{})
swag.Register("swagger", &s{})
Not quite sure where this is coming from, but probably fine to have. What swag version do you have installed?
Which is the latest one.
I think it should be fine then.
Just checked with curl and it works without issues.
WIP: Enable a list to be moved across namespacesto Enable a list to be moved across namespacesLooks good, will merge once the pipeline succeeds.