vikunja/vikunja
8
54
Fork 94
Code Issues 130 Pull Requests 35 Packages Releases 37 Activity

expand relative path ~/.config/vikunja to $HOME/.config/vikunja **WINDOWS** #147

Merged
konrad merged 9 commits from funkythings/api:windows-env-compat into master 2020-03-20 21:21:44 +00:00
Conversation 10 Commits 9 Files Changed 3 +17 -8
funkythings commented 2020-02-27 11:22:58 +00:00
Contributor
Copy Link

Same as #146, but compatible with windows paths. Not sure actually HOW the backend runs on windows with paths like /etc/vikunja etc...Just in case

Same as #146, but compatible with windows paths. Not sure actually HOW the backend runs on windows with paths like `/etc/vikunja` etc...Just in case
funkythings changed title from WIP: expand relative path ~/.config/vikunja to $HOME/.config/vikunja to WIP: expand relative path ~/.config/vikunja to $HOME **WINDOWS**/.config/vikunja 2020-02-27 11:24:01 +00:00
funkythings changed title from WIP: expand relative path ~/.config/vikunja to $HOME **WINDOWS**/.config/vikunja to WIP: expand relative path ~/.config/vikunja to $HOME/.config/vikunja **WINDOWS** 2020-02-27 11:24:12 +00:00
konrad reviewed 2020-02-28 21:01:53 +00:00
konrad left a comment
Owner
Copy Link

Please run go mod tidy, go mod vendor and commit the result.

Please run `go mod tidy`, `go mod vendor` and commit the result.
funkythings changed title from WIP: expand relative path ~/.config/vikunja to $HOME/.config/vikunja **WINDOWS** to expand relative path ~/.config/vikunja to $HOME/.config/vikunja **WINDOWS** 2020-02-29 10:28:45 +00:00
konrad commented 2020-02-29 19:52:36 +00:00
Owner
Copy Link

@funkythings Please resolve conflicts (I think these came through merging #146)

@funkythings Please resolve conflicts (I think these came through merging #146)
funkythings commented 2020-03-01 16:36:54 +00:00
Author
Contributor
Copy Link

I'm confused, did you merge #146 with master first? And now want to merge #147?

I'm confused, did you merge #146 with master first? And now want to merge #147?
konrad commented 2020-03-01 16:59:10 +00:00
Owner
Copy Link

#146 is merged yes. It seems like I did not pay attention at the similarities of these two PRs. Sorry for that.

I would prefer if this one could get merged, since as you already stated it has better compatibility with Windows etc - even if it basically overrides the changes made in #146.

#146 is merged yes. It seems like I did not pay attention at the similarities of these two PRs. Sorry for that. I would prefer if this one could get merged, since as you already stated it has better compatibility with Windows etc - even if it basically overrides the changes made in #146.
funkythings commented 2020-03-13 17:33:48 +00:00
Author
Contributor
Copy Link

Ok, sry for the delay. I had to send my laptop in for repair. Will take a look as soon as possible

Ok, sry for the delay. I had to send my laptop in for repair. Will take a look as soon as possible
👍 1
funkythings commented 2020-03-17 09:01:17 +00:00
Author
Contributor
Copy Link

Should do it

Should do it
funkythings commented 2020-03-17 09:13:18 +00:00
Author
Contributor
Copy Link

I can push a tiny change to make more clear, which of the many possible config file locations where actually used. Are you interested in that? Helped me out in debugging an issue in a yml file a lot. I can imagine this information is useful for people, in case they run into similar issues.

I can push a tiny change to make more clear, *which* of the many possible config file locations where actually used. Are you interested in that? Helped me out in debugging an issue in a `yml` file a lot. I can imagine this information is useful for people, in case they run into similar issues.
konrad commented 2020-03-17 19:47:02 +00:00
Owner
Copy Link

Adding extra bit of information sounds like aa great idea, please go ahead!

Adding extra bit of information sounds like aa great idea, please go ahead!
funkythings commented 2020-03-20 20:06:58 +00:00
Author
Contributor
Copy Link

Added the bit of information, plus formatted. Vim messed it up

I also fixed the default yaml config file with a single pair of "" at the right spot.

Added the bit of information, plus formatted. Vim messed it up I also fixed the default yaml config file with a single pair of "" at the right spot.
konrad approved these changes 2020-03-20 21:20:09 +00:00
konrad left a comment
Owner
Copy Link

Looks good, thanks.

Looks good, thanks.
konrad closed this pull request 2020-03-20 21:21:44 +00:00
konrad deleted branch windows-env-compat 2020-03-20 21:21:52 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#147
No description provided.
Delete Branch "funkythings/api:windows-env-compat"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?