WIP: feat(docker): Add ability to substitute env vars with _file vars #1621

donor_extortion · 2023-10-14T04:01:30Z

donor_extortion commented

2023-10-14 04:01:30 +00:00

First-time contributor

Allows usage of _FILE env vars for docker as mentioned in #704. Uses the solution linked in the comments minus the bash-isms (wasn't sure if you wanted to add bash to the image). Instead of manually specifying individual vars, it loops over all env vars checking if they start with VIKUNJA and end with _FILE.

Also wasn't sure if the docs should be in the main config page where it explains env var usage or if it should go in one of the docker specific pages.

Resolves #704

Allows usage of `_FILE` env vars for docker as mentioned in #704. Uses the solution linked in the comments minus the bash-isms (wasn't sure if you wanted to add bash to the image). Instead of manually specifying individual vars, it loops over all env vars checking if they start with `VIKUNJA` and end with `_FILE`. Also wasn't sure if the docs should be in the main config page where it explains env var usage or if it should go in one of the docker specific pages. Resolves #704

donor_extortion added 2 commits 2023-10-14 04:01:32 +00:00

d275c47b07 add ability to substitute env vars with _file vars

continuous-integration/drone/pr Build is passing Details

e96bf64dc0 add documentation

konrad reviewed 2023-10-17 16:18:40 +00:00

konrad left a comment

Thanks for the PR!

I kind of hate to say this, but could you change it so that the file loading logic is happening directly in Vikunja and not in the entrypoint only? That would allow using this in native installations in e.g. nixos as well which do not use docker.

Thanks for the PR! I kind of hate to say this, but could you change it so that the file loading logic is happening directly in Vikunja and not in the entrypoint only? That would allow using this in native installations in e.g. nixos as well which do not use docker.

👍 1

donor_extortion changed title from ~~feat(docker): Add ability to substitute env vars with _file vars~~ to WIP: feat(docker): Add ability to substitute env vars with _file vars

2023-10-18 19:44:19 +00:00

donor_extortion changed title from ~~WIP: feat(docker): Add ability to substitute env vars with _file vars~~ to WIP: feat(docker): Add ability to substitute env vars with _file vars

2023-10-18 19:44:24 +00:00

konrad commented

2024-01-16 12:18:21 +00:00

Hey @donor_extortion are you still interested in this?

donor_extortion commented

2024-01-16 22:00:52 +00:00

First-time contributor

I got distracted by other things and completely forgot about this. I am still interested, though, it's unlikely I'd be able to work on it any time soon.

👍 1

konrad referenced this issue from a commit

2024-02-07 14:00:32 +00:00

fix(deps): update sentry-javascript monorepo to v6.18.1 (#1621)

continuous-integration/drone/pr Build is passing

Required

Details

This pull request has changes conflicting with the target branch.