vikunja
/
vikunja
6
43
Fork 71
Code Issues 150 Pull Requests 15 Packages Releases 32 Activity

fix(migration): Trello checklists #2140

Merged
konrad merged 7 commits from cr-insane/vikunja:fix-trello-checklist into main 2024-03-09 09:01:05 +00:00
Conversation 5 Commits 7 Files Changed 2 +13 -11
cr-insane commented 2024-02-28 16:15:06 +00:00
Contributor
Copy Link

Importing checklists from trello didnt work with the markdown. Changed it to the corresponding HTML Tags

Importing checklists from trello didnt work with the markdown. Changed it to the corresponding HTML Tags
cr-insane added 1 commit 2024-02-28 16:15:08 +00:00
cr-insane changed title from Importing checklists from trello didnt work with the markdown. Changed it to the corresponding HTML Tags to fix(api): Trello checklists 2024-02-28 16:16:32 +00:00
cr-insane changed title from fix(api): Trello checklists to fix(migration): Trello checklists 2024-02-28 16:26:48 +00:00
konrad requested changes 2024-02-28 22:05:55 +00:00
Dismissed
konrad left a comment
Owner
Copy Link

Thanks for the PR!

Please take a look at the failing ci pipeline and fix the failing test assertions.

Thanks for the PR! Please take a look at the failing ci pipeline and fix the failing test assertions.
cr-insane added 1 commit 2024-03-02 01:04:55 +00:00
continuous-integration/drone/pr Build is failing Details
0f1347a016 Merge branch 'main' into fix-trello-checklist
frederick commented 2024-03-02 01:13:24 +00:00
Member
Copy Link

Hi cr-insane!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2140-fix-trello-checklist--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi cr-insane! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2140-fix-trello-checklist--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
cr-insane commented 2024-03-02 01:16:52 +00:00
Author
Contributor
Copy Link

After taking another look at this I am realizing, that the issue probably isn't in the import itself rather than in parsing the markdown tags in the frontend. I have no idea how to fix this in the frontend, sorry.

After taking another look at this I am realizing, that the issue probably isn't in the import itself rather than in parsing the markdown tags in the frontend. I have no idea how to fix this in the frontend, sorry.
konrad commented 2024-03-02 07:19:58 +00:00
Owner
Copy Link

After taking another look at this I am realizing, that the issue probably isn't in the import itself rather than in parsing the markdown tags in the frontend. I have no idea how to fix this in the frontend, sorry.

I think what you're doing is on the right track. What makes you think it's a frontend issue?

> After taking another look at this I am realizing, that the issue probably isn't in the import itself rather than in parsing the markdown tags in the frontend. I have no idea how to fix this in the frontend, sorry. I think what you're doing is on the right track. What makes you think it's a frontend issue?
cr-insane force-pushed fix-trello-checklist from 0f1347a016 to 7cdb4d7508 2024-03-03 02:57:07 +00:00 Compare
cr-insane commented 2024-03-03 02:59:39 +00:00
Author
Contributor
Copy Link

My thinking was, that the issue is in parsing the description with markup tags. While the markup tags work, when using the built in editor, they don't work. But I thought about it again and I think you are right :D

Sorry, atm I only have time for that stuff late and night, so my brain might be a bit foggy

My thinking was, that the issue is in parsing the description with markup tags. While the markup tags work, when using the built in editor, they don't work. But I thought about it again and I think you are right :D Sorry, atm I only have time for that stuff late and night, so my brain might be a bit foggy
cr-insane added 1 commit 2024-03-03 03:08:26 +00:00
continuous-integration/drone/pr Build is failing Details
6a23f86969 fixing tabs in test... ooopsie
cr-insane added 1 commit 2024-03-03 03:49:48 +00:00
continuous-integration/drone/pr Build is failing Details
a58483f1f1 Trying to fix tests, but failing
cr-insane commented 2024-03-03 03:50:25 +00:00
Author
Contributor
Copy Link

I had some more errors in the test. It was easier, when I figured out how to run the tests locally.
But now I cant see anymore differences and I would appreciate a little headsup.

I had some more errors in the test. It was easier, when I figured out how to run the tests locally. But now I cant see anymore differences and I would appreciate a little headsup.
cr-insane added 1 commit 2024-03-03 16:18:55 +00:00
continuous-integration/drone/pr Build is failing Details
0e74b584e8 typo
cr-insane added 1 commit 2024-03-03 16:19:25 +00:00
continuous-integration/drone/pr Build is failing Details
e5d46d51ea Merge branch 'main' into fix-trello-checklist
konrad reviewed 2024-03-03 21:22:30 +00:00
pkg/modules/migration/trello/trello.go Outdated
@ -232,3 +232,3 @@
// Checklists (as markdown in description)
for _, checklist := range card.Checklists {
task.Description += "\n\n## " + checklist.Name + "\n"
task.Description += "\n\n<h1> " + checklist.Name + "</h1>\n\n<ul data-type='taskList'>"
konrad commented 2024-03-03 21:22:13 +00:00
Owner
Copy Link

Please make this an h2, as it was before.

Please make this an `h2`, as it was before.
cr-insane marked this conversation as resolved
konrad reviewed 2024-03-03 21:23:29 +00:00
pkg/modules/migration/trello/trello.go Outdated
@ -238,2 +237,3 @@
task.Description += "\n"
if item.State == "complete" {
task.Description += "[x]"
task.Description += "<li data-checked='true' data-type='taskItem'><label><input type='checkbox' checked='checked'><span></span></label><div><p>"
konrad commented 2024-03-03 21:23:24 +00:00
Owner
Copy Link

Does this work if you use " instead of '?

Does this work if you use `"` instead of `'`?
cr-insane commented 2024-03-03 23:28:23 +00:00
Author
Contributor
Copy Link

unfortunately not :/

unfortunately not :/
cr-insane force-pushed fix-trello-checklist from e5d46d51ea to 0e74b584e8 2024-03-03 23:27:39 +00:00 Compare
cr-insane added 1 commit 2024-03-03 23:28:45 +00:00
continuous-integration/drone/pr Build is failing Details
25be8a5eef Merge branch 'main' into fix-trello-checklist
cr-insane force-pushed fix-trello-checklist from 25be8a5eef to 0e74b584e8 2024-03-03 23:29:57 +00:00 Compare
konrad added 2 commits 2024-03-09 08:49:17 +00:00
continuous-integration/drone/pr Build is passing Details
505b48bc9b
fix(migration): convert trello checklists to html
konrad approved these changes 2024-03-09 08:50:02 +00:00
konrad left a comment
Owner
Copy Link

Thanks again! I've fixed the little things, should be good now.

Thanks again! I've fixed the little things, should be good now.
konrad scheduled this pull request to auto merge when all checks succeed 2024-03-09 08:50:31 +00:00
konrad merged commit 86983f50d4 into main 2024-03-09 09:01:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
konrad
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#2140
No description provided.
Delete Branch "cr-insane/vikunja:fix-trello-checklist"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?