vikunja
/
vikunja
6
43
Fork 72
Code Issues 150 Pull Requests 19 Packages Releases 32 Activity

feat: add config flag to configure default project view #2154

Closed
waza-ari wants to merge 6 commits from waza-ari/vikunja:add-default-view into main
pull from: waza-ari/vikunja:add-default-view
merge into: vikunja:main
Conversation 4 Commits 6 Files Changed 9 +34 -1
waza-ari commented 2024-03-02 17:51:23 +00:00
Contributor
Copy Link

Fixes #2153

Fixes #2153
waza-ari added 1 commit 2024-03-02 17:51:24 +00:00
continuous-integration/drone/pr Build is failing Details
ef483c7dc3 feat: add config flag to configure default project view
waza-ari added 1 commit 2024-03-02 18:14:59 +00:00
waza-ari added 1 commit 2024-03-02 18:20:22 +00:00
frederick commented 2024-03-02 18:22:11 +00:00
Member
Copy Link

Hi waza-ari!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2154-add-default-view--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi waza-ari! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2154-add-default-view--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
waza-ari added 1 commit 2024-03-02 23:34:45 +00:00
continuous-integration/drone/pr Build is failing Details
00aa05206d fix: update swagger docs
waza-ari commented 2024-03-02 23:46:03 +00:00
Author
Contributor
Copy Link

I'm honestly not sure why the tests are failing. Maybe I'm missing a step or missing something obvious, any help would be appreciated ;)

Edit: I'm pretty sure the issue is the same as described here, as the config store would be used when importing the router index.

Edit 2: Never mind, guess I figured it out after all. Would be nice if that makes it into the next release :)

I'm honestly not sure why the tests are failing. Maybe I'm missing a step or missing something obvious, any help would be appreciated ;) Edit: I'm pretty sure the issue is the same as [described here](https://pinia.esm.dev/core-concepts/outside-component-usage.html), as the config store would be used when importing the router index. Edit 2: Never mind, guess I figured it out after all. Would be nice if that makes it into the next release :)
waza-ari added 1 commit 2024-03-03 00:05:16 +00:00
waza-ari added 1 commit 2024-03-03 08:20:41 +00:00
continuous-integration/drone/pr Build is passing Details
290c4d0e7b fix: do not use computed outside of components...
waza-ari requested review from konrad 2024-03-03 12:42:45 +00:00
konrad commented 2024-03-03 21:37:52 +00:00
Owner
Copy Link

Hey! That was a fast issue-to-pr time.

Unfortunately, I can't merge this as it is now, for two reasons:

  1. The way views work will fundamentally change in the next release, which will essentially require a rewrite of the whole thing as you implemented it now (and you couldn't have known this, I guess that's on me). Given how small your implementation is, I'd rather reimplement this instead of merging it now and then reworking it once that change lands.
  2. I think this should be a per-user or per-project setting, not globally defined.

Let's take a step back and discuss this further in the issue you opened about this.

Hey! That was a fast issue-to-pr time. Unfortunately, I can't merge this as it is now, for two reasons: 1. The way views work will fundamentally change in the next release, which will essentially require a rewrite of the whole thing as you implemented it now (and you couldn't have known this, I guess that's on me). Given how small your implementation is, I'd rather reimplement this instead of merging it now and then reworking it once that change lands. 2. I think this should be a per-user or per-project setting, not globally defined. Let's take a step back and discuss this further in the issue you opened about this.
👍 1
waza-ari commented 2024-03-04 13:44:11 +00:00
Author
Contributor
Copy Link

Okay no worries. Guess it was a nice starter exercise to get into Go and Vue a little bit. I saw the item on the public roadmap a little bit later and figured that it would've been better to first create the issue and discuss before submitting a PR.

Okay no worries. Guess it was a nice starter exercise to get into Go and Vue a little bit. I saw the item on the public roadmap a little bit later and figured that it would've been better to first create the issue and discuss before submitting a PR.
👍 1
waza-ari closed this pull request 2024-03-04 13:44:11 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
konrad
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#2154
No description provided.
Delete Branch "waza-ari/vikunja:add-default-view"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?