vikunja
/
vikunja
6
43
Fork 71
Code Issues 150 Pull Requests 15 Packages Releases 32 Activity

docs: clarify what to use for OIDC authurl #2180

Merged
konrad merged 1 commits from waza-ari/vikunja:openid-doc-changes into main 2024-03-10 11:39:25 +00:00
Conversation 1 Commits 1 Files Changed 1 +7 -3
waza-ari commented 2024-03-09 20:50:31 +00:00
Contributor
Copy Link

There's been a question on the community where confusion on what exactly to use for authurl lead to some frustration.

The authurl is actually passed to oidc.NewProvider, so it should be the URL supporting OIDC discovery.

There's been a [question on the community](https://community.vikunja.io/t/cant-get-openid-connect-to-work/2115) where confusion on what exactly to use for `authurl` lead to some frustration. The `authurl` is actually [passed to](https://kolaente.dev/vikunja/vikunja/src/commit/86983f50d4338cbffa3622585331b32cf35e0287/pkg/modules/auth/openid/openid.go#L75) `oidc.NewProvider`, so it should be the URL supporting OIDC discovery.
waza-ari added 1 commit 2024-03-09 20:50:33 +00:00
continuous-integration/drone/pr Build is passing Details
23f1223ac3 docs: clarify what to use for authurl
frederick commented 2024-03-09 21:02:07 +00:00
Member
Copy Link

Hi waza-ari!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2180-openid-doc-changes--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi waza-ari! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2180-openid-doc-changes--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad approved these changes 2024-03-10 11:39:19 +00:00
konrad merged commit 6e52db76dc into main 2024-03-10 11:39:25 +00:00
konrad deleted branch openid-doc-changes 2024-03-10 11:39:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
konrad
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#2180
No description provided.
Delete Branch "waza-ari/vikunja:openid-doc-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?