vikunja/vikunja
5
48
Fork 86
Code Issues 152 Pull Requests 37 Packages Releases 37 Activity

Frontend: Task List Visual Improvements #2264

Merged
konrad merged 4 commits from Elscrux/vikunja:feature/improved-task-lists into main 2024-04-11 15:46:45 +00:00
Conversation 1 Commits 4 Files Changed 2 +8 -2
Elscrux commented 2024-04-10 22:36:57 +00:00
Contributor
Copy Link

This makes task lists (especially big ones) easier to read. I've set a margin so there is a distance between task items which makes them easier to stand out.
I've also changed the visuals of the checked elements (strikethrough + grey font color) so the unchecked ones stand out more. Note that this currently seems to be a big bugged outside of edit mode as data-checked doesn't seem to be updating correctly in this state which seems to be an issue that is already noted for the TipTap editor.

I also wanted to add a feature to drag and drop task items to reorder them, but wasn't successful so far. If someone else could try it, that'd be great though!

Before:

before.png

After:

after.png

This makes task lists (especially big ones) easier to read. I've set a margin so there is a distance between task items which makes them easier to stand out. I've also changed the visuals of the checked elements (strikethrough + grey font color) so the unchecked ones stand out more. Note that this currently seems to be a big bugged outside of edit mode as `data-checked` doesn't seem to be updating correctly in this state which seems to be an issue that is already noted for the TipTap editor. I also wanted to add a feature to drag and drop task items to reorder them, but wasn't successful so far. If someone else could try it, that'd be great though! ### Before: ![before.png](/attachments/87092fec-7d93-48fb-a35e-11f63689d17f) ### After: ![after.png](/attachments/79a9d81f-bacb-44bb-943b-3519681275ba)
before.png
57 KiB
after.png
58 KiB
Elscrux added 3 commits 2024-04-10 22:36:59 +00:00 
Makes it them more readable and easier to distinguish multi line task items
Make unchecked boxes stand out more
Some checks reported errors
continuous-integration/drone/pr Build was killed
Details
5a5b86438c
Elscrux added 1 commit 2024-04-10 22:37:26 +00:00
Merge branch 'main' into feature/improved-task-lists
All checks were successful
continuous-integration/drone/pr Build is passing
Details
8ca3916118
Elscrux changed title from Task List Visual Improvements to Frontend: Task List Visual Improvements 2024-04-10 22:41:12 +00:00
frederick commented 2024-04-10 22:52:34 +00:00
Member
Copy Link

Hi Elscrux!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2264-feature-improved-task-lists--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi Elscrux! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2264-feature-improved-task-lists--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad approved these changes 2024-04-11 15:45:08 +00:00
konrad left a comment
Owner
Copy Link

Thanks!

Thanks!
konrad merged commit a3a4d05e89 into main 2024-04-11 15:46:45 +00:00
konrad deleted branch feature/improved-task-lists 2024-04-11 15:46:46 +00:00
dpschen reviewed 2024-06-26 09:54:27 +00:00
frontend/vite.config.ts
@ -18,3 +18,3 @@
const pathSrc = fileURLToPath(new URL('./src', import.meta.url))
const pathSrc = fileURLToPath(new URL('./src', import.meta.url)).replaceAll('\\', '/')
dpschen commented 2024-06-26 09:54:27 +00:00
Member
Copy Link

👋 Hey @Elscrux:

out of interest: what was the replacement of '\' with '/' for?

👋 Hey @Elscrux: out of interest: what was the replacement of '\\' with '/' for?
Elscrux commented 2024-06-26 17:06:47 +00:00
Author
Contributor
Copy Link

This was required to make the build work locally on my machine. Otherwise the files couldn't be read apparently.

This was required to make the build work locally on my machine. Otherwise the files couldn't be read apparently.
dpschen commented 2024-06-26 17:35:24 +00:00
Member
Copy Link

Thanks.
Was there a file path displayed that caused this error?

I'm asking because I remember that the path of some imported component contained //. I fixed that just recently (can't find commit right now, but if necessary I can look it up).

Thanks. Was there a file path displayed that caused this error? I'm asking because I remember that the path of some imported component contained `//`. I fixed that just recently (can't find commit right now, but if necessary I can look it up).
Elscrux commented 2024-06-26 17:37:28 +00:00
Author
Contributor
Copy Link

I'm afraid I don't remember the error

I'm afraid I don't remember the error
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#2264
No description provided.
Delete Branch "Elscrux/vikunja:feature/improved-task-lists"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?