vikunja
/
vikunja
6
43
Fork 71
Code Issues 150 Pull Requests 18 Packages Releases 32 Activity

Frontend: Proof of concept for image preview #2266

Open
Elscrux wants to merge 2 commits from Elscrux/vikunja:feature/image-preview into main
pull from: Elscrux/vikunja:feature/image-preview
merge into: vikunja:main
Conversation 4 Commits 2 Files Changed 2 +136 -77
Elscrux commented 2024-04-10 22:52:06 +00:00
Contributor
Copy Link

Adds a proof of concept preview for all images inside the task itself (not related to the cover image feature). Basically it is very convenient to show all images in a task when you click on it, rather than having to individually open images when you search for a specific one or if you want to get a quick overview.
This implementation shows how it could work, but is probably not the best way to do it. Please let me know what you think!

Adds a proof of concept preview for all images inside the task itself (not related to the cover image feature). Basically it is very convenient to show all images in a task when you click on it, rather than having to individually open images when you search for a specific one or if you want to get a quick overview. This implementation shows how it could work, but is probably not the best way to do it. Please let me know what you think!
Elscrux added 1 commit 2024-04-10 22:52:09 +00:00
continuous-integration/drone/pr Build is passing Details
4da881aa99 Proof of concept for image preview
frederick commented 2024-04-10 23:21:45 +00:00
Member
Copy Link

Hi Elscrux!

Thank you for creating a PR!

I've deployed the frontend changes of this PR on a preview environment under this URL: https://2266-feature-image-preview--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/.

This preview does not contain any changes made to the api, only the frontend.

Have a nice day!

Beep boop, I'm a bot.

Hi Elscrux! Thank you for creating a PR! I've deployed the frontend changes of this PR on a preview environment under this URL: https://2266-feature-image-preview--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somewhere. The easiest to use is https://try.vikunja.io/. This preview does not contain any changes made to the api, only the frontend. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2024-04-11 15:37:40 +00:00
Owner
Copy Link

Needs some styling, but I like the idea!

Needs some styling, but I like the idea!
konrad reviewed 2024-04-11 15:40:04 +00:00
frontend/src/components/tasks/partials/attachments.vue Outdated
@ -67,6 +67,12 @@
{{ a.file.mime }}
</span>
</p>
<img
konrad commented 2024-04-11 15:40:04 +00:00
Owner
Copy Link

I would extract this out into its own component, which takes the attachment, fetches the image and shows it next to the attachment. We could extend this further to show some kind of icon for pdfs or other file types later on.

I would extract this out into its own component, which takes the attachment, fetches the image and shows it next to the attachment. We could extend this further to show some kind of icon for pdfs or other file types later on.
Elscrux commented 2024-04-26 17:05:57 +00:00
Author
Contributor
Copy Link

Good point, I did that

Good point, I did that
konrad commented 2024-04-11 15:40:35 +00:00
Owner
Copy Link

It also seems like the preview is not shown when the file is initially uploaded.

It also seems like the preview is not shown when the file is initially uploaded.
Elscrux force-pushed feature/image-preview from 4da881aa99 to be50d3d7b3 2024-04-26 17:05:28 +00:00 Compare
Elscrux changed title from WIP: Frontend: Proof of concept for image preview to Frontend: Proof of concept for image preview 2024-04-26 17:05:54 +00:00
Elscrux commented 2024-04-26 17:07:47 +00:00
Author
Contributor
Copy Link

@konrad

It also seems like the preview is not shown when the file is initially uploaded.

This should be fixed now.

Needs some styling, but I like the idea!

I styled it in a way so it's displaying like a table. I'm not super used to doing styling so please feel free to touch this up :)

@konrad > It also seems like the preview is not shown when the file is initially uploaded. This should be fixed now. > Needs some styling, but I like the idea! I styled it in a way so it's displaying like a table. I'm not super used to doing styling so please feel free to touch this up :)
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
dependencies

   
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
needs reproduction

   
question

More information is needed

  
security

   
wontfix

This won't be fixed

No Label
dependencies
duplicate
help wanted
invalid
kind/bug
kind/feature
needs reproduction
question
security
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#2266
No description provided.
Delete Branch "Elscrux/vikunja:feature/image-preview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?