Migrate all timestamps to real iso dates #594

Merged

konrad merged 50 commits from feature/datetime into master 2020-06-27 17:04:18 +00:00

Conversation 0 Commits 50 Files Changed 83 +2208 -1257

konrad commented 2020-06-21 21:22:53 +00:00

Owner

Copy Link

Description

Currently, unix timestamps are used everywhere. These should be real iso timestamps, not those fake timeutil.Timestamp stuff.

Todo

• Better error messages for failed migration steps to tell about what went wrong
• Migrations for sqlite
• Change the names of _unix fields in structs
  • Remove suffix adding hacks in filters and such
• Change definitions to use time.Time everywhere instead of the hacky timestamp thingy
• Remove timeutil
• Make sure all tests still pass

# Description Currently, unix timestamps are used everywhere. These should be real iso timestamps, not those fake `timeutil.Timestamp` stuff. # Todo * [x] Better error messages for failed migration steps to tell about what went wrong * [x] Migrations for sqlite * [x] Change the names of `_unix` fields in structs * [x] Remove suffix adding hacks in filters and such * [x] Change definitions to use `time.Time` everywhere instead of the hacky timestamp thingy * [x] Remove timeutil * [x] Make sure all tests still pass

konrad added 3 commits 2020-06-21 21:22:53 +00:00

Fail with an error if trying to use an unsupported dbms 1a5e245b9e

Start adding migration for time.Time d3cf78cb8d

Fix sql statement for mysql 46003efc50

konrad added 3 commits 2020-06-22 19:38:06 +00:00

Merge branch 'master' into feature/datetime 557be7c334

Fix sql migration query for mysql 155371a3fd

Merge branch 'master' into feature/datetime c91a791a4d

konrad added 1 commit 2020-06-22 19:56:41 +00:00

Add all tables and columns for migration 78757162ab

konrad added 2 commits 2020-06-22 20:20:31 +00:00

Automatically rename _unix suffix 6092fbd78d

Convert 0 to null in timestamps f45ed9453d

konrad added 3 commits 2020-06-22 20:57:43 +00:00

Convert 0 unix timestamps to null in postgres 5a94a18e02

Add converting sqlite values b756ffea19

SQLite stub d9ba8b96c2

konrad added 1 commit 2020-06-23 21:26:31 +00:00

Add migration script for sqlite e3e27ab94b

konrad added 1 commit 2020-06-23 21:36:07 +00:00

Make sure to not migrate 0 unix timestamps to 1970 iso dates 0bbe6b93b5

konrad added 1 commit 2020-06-23 21:38:21 +00:00

Add better error messages when running migrations 11df4b85e8

konrad added 5 commits 2020-06-25 15:39:15 +00:00

Fix sqlite path in default config f2025c2658

Update golang.org/x/crypto commit hash to 75b2880 (#596) ... 7b31301f09

Update golang.org/x/crypto commit hash to 75b2880

Reviewed-on: vikunja/api#596

Add better errors if the sqlite db file is not writable caee123f9d

Enable upload backgrounds by default c8605d6b3d

Merge branch 'master' into feature/datetime 6ef4a915b1

konrad added 1 commit 2020-06-25 22:08:54 +00:00

Merge branch 'master' into feature/datetime 0443863b8b

konrad added 1 commit 2020-06-25 22:39:43 +00:00

Merge branch 'master' into feature/datetime ff152e4d0d

konrad added 4 commits 2020-06-26 15:36:20 +00:00

Remove all Unix suffixes in field names 01c2b57950

Move all timeutil.TimeStamp to time.Time e34ebfdee9

Remove _unix suffix 48b8644e18

Remove adding _unix suffix hack 13e17c2ee8

konrad added 1 commit 2020-06-26 15:37:49 +00:00

Remove timeutil package 65ec94786a

konrad added 1 commit 2020-06-26 16:36:44 +00:00

Partially fix tests 09c9780bb9

konrad referenced this pull request from vikunja/frontend 2020-06-26 17:25:10 +00:00

Fix Datetime Handling #168

konrad added 3 commits 2020-06-26 17:49:12 +00:00

Fix test fixtures 52779503bd

Merge branch 'master' into feature/datetime 937bf85646

Fix misspell 9137c549d2

konrad added 1 commit 2020-06-26 17:55:39 +00:00

Fix test fixtures 831242c4ff

konrad added 1 commit 2020-06-26 17:59:26 +00:00

Fix lint 6ae9ea3bee

konrad added 1 commit 2020-06-26 20:27:28 +00:00

Set created and updated timestamps for all fixtures d55e9f5d9a

konrad added 2 commits 2020-06-26 22:27:29 +00:00

Set db timezone 60a51b1f37

Change fixtures time zone to gmt 58e044bb36

konrad added 1 commit 2020-06-26 22:48:34 +00:00

Properly set timezone 85babcbbb3

konrad added 1 commit 2020-06-27 10:38:43 +00:00

Fix tests and fixtures for date timezone stuff 4853fc7824

konrad added 2 commits 2020-06-27 11:05:15 +00:00

Fix lint 94bfcc3b19

Fix task filter a65e2e15b5

konrad added 2 commits 2020-06-27 11:26:07 +00:00

Remove task collection date hack 9fc8ffe10b

Fix integration tests 139d2a4723

konrad added 1 commit 2020-06-27 11:47:39 +00:00

Add error and test for invalid filter values d4e0dac28b

konrad added 2 commits 2020-06-27 13:59:10 +00:00

Use timezone from config d4aebf7b11

Fix caldav reminder parsing 1da298f3fe

konrad added 2 commits 2020-06-27 14:06:02 +00:00

Fix import eae5fcfabf

Fix timezone setting for wunderlist parsing 9f670194f2

konrad added 1 commit 2020-06-27 14:19:18 +00:00

Fix timezone setting for todoist parsing 0eae995316

konrad added 1 commit 2020-06-27 14:36:47 +00:00

Merge branch 'master' into feature/datetime 12d73063d0

konrad added 1 commit 2020-06-27 14:52:51 +00:00

Fix null filter 0f6fac2e56

konrad added 1 commit 2020-06-27 15:39:28 +00:00

Always set db time to gmt e4bb42b46c

konrad added 1 commit 2020-06-27 16:10:47 +00:00

Add option to include null results when filtering cc688f0594

konrad added 2 commits 2020-06-27 16:27:37 +00:00

Fix query param name c73873a5ff

"fix" gocyclo f945d6b74a

konrad referenced this issue from a commit 2020-06-27 17:04:05 +00:00

Migrate all timestamps to real iso dates (#594)

konrad merged commit 08205008e7 into master 2020-06-27 17:04:06 +00:00

konrad deleted branch feature/datetime 2020-06-27 17:04:24 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

dependencies

duplicate

This issue or pull request already exists

help wanted

Need some help

invalid

Something is wrong

kind/bug

Something is not working

kind/feature

New feature

moved-to-github

needs reproduction

question

More information is needed

security

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

dpschen frederick konrad renovate shilch

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/vikunja#594

No description provided.