vikunja/vikunja
8
54
Fork 94
Code Issues 130 Pull Requests 36 Packages Releases 37 Activity

Support absolute iCal timestamps in CalDAV requests #691

Merged
konrad merged 3 commits from freaktechnik/api:ical-timestamps into master 2020-10-19 09:11:16 +00:00
Conversation 1 Commits 3 Files Changed 2 +10 -2
freaktechnik commented 2020-10-18 21:12:58 +00:00
Contributor
Copy Link

Description

Adds support for absolute timestamps in incoming CalDAV requests. Still completely ignores the timezone handling for other formats (either with TZID on the prop or using the global timezone). At least I didn't see any place where that would be handled...

I've tested this with OpenTasks and creation, editing (and completion, which is just an edit, I think) work fine now.

Checklist

  • I added or improved tests
  • I added or improved docs for my feature
    • Swagger (including mage do-the-swag)
    • Error codes
    • New config options (including adding them to config.yml.saml and running mage generate-docs)
# Description Adds support for absolute timestamps in incoming CalDAV requests. Still completely ignores the timezone handling for other formats (either with TZID on the prop or using the global timezone). At least I didn't see any place where that would be handled... I've tested this with OpenTasks and creation, editing (and completion, which is just an edit, I think) work fine now. # Checklist * [ ] I added or improved tests * [ ] I added or improved docs for my feature * [ ] Swagger (including `mage do-the-swag`) * [ ] Error codes * [ ] New config options (including adding them to `config.yml.saml` and running `mage generate-docs`)
freaktechnik added 2 commits 2020-10-18 21:12:59 +00:00
no need to export from there I think
All checks were successful
continuous-integration/drone/pr Build is passing
Details
eb22b11d58
konrad added 1 commit 2020-10-19 07:24:11 +00:00
Merge branch 'master' into ical-timestamps
All checks were successful
continuous-integration/drone/pr Build is passing
Details
299da5459b
konrad commented 2020-10-19 07:24:50 +00:00
Owner
Copy Link

Thanks! I'll merge once ci passes.

Thanks! I'll merge once ci passes.
konrad merged commit 214f2f008e into master 2020-10-19 09:11:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#691
No description provided.
Delete Branch "freaktechnik/api:ical-timestamps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?