vikunja/vikunja
8
54
Fork 94
Code Issues 130 Pull Requests 35 Packages Releases 37 Activity

Fix completion status in DAV for OpenTasks and multiline descriptions #697

Merged
konrad merged 3 commits from freaktechnik/api:completed-ts into master 2020-10-21 21:03:20 +00:00
Conversation 2 Commits 3 Files Changed 2 +133 -3
freaktechnik commented 2020-10-21 20:13:56 +00:00
Contributor
Copy Link

Description

This fixes the completion state of tasks in OpenTasks not working correctly. It also fixes multiline descriptions, since newlines are reserved in iCal for new properties (unless you indent with two spaces, which is for formatting because 80 chars wide is way better or something).

Checklist

  • I added or improved tests
  • I added or improved docs for my feature
    • Swagger (including mage do-the-swag)
    • Error codes
    • New config options (including adding them to config.yml.saml and running mage generate-docs)
# Description This fixes the completion state of tasks in OpenTasks not working correctly. It also fixes multiline descriptions, since newlines are reserved in iCal for new properties (unless you indent with two spaces, which is for formatting because 80 chars wide is way better or something). # Checklist * [x] I added or improved tests * [ ] I added or improved docs for my feature * [ ] Swagger (including `mage do-the-swag`) * [ ] Error codes * [ ] New config options (including adding them to `config.yml.saml` and running `mage generate-docs`)
freaktechnik added 2 commits 2020-10-21 20:13:58 +00:00
fix caldav descriptions
All checks were successful
continuous-integration/drone/pr Build is passing
Details
319cdbfc87
konrad reviewed 2020-10-21 20:28:27 +00:00
konrad left a comment
Owner
Copy Link

Looks great! Could you add a test for this behaviour?

Looks great! Could you add a test for this behaviour?
freaktechnik added 1 commit 2020-10-21 20:50:19 +00:00
add tests for multiline descriptions and completed state
All checks were successful
continuous-integration/drone/pr Build is passing
Details
6dff1d941c
konrad merged commit ffce9b51cc into master 2020-10-21 21:03:20 +00:00
konrad commented 2020-10-21 21:03:26 +00:00
Owner
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dpschen frederick konrad renovate shilch
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#697
No description provided.
Delete Branch "freaktechnik/api:completed-ts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?