vikunja/vikunja
5
49
Fork 88
Code Issues 131 Pull Requests 32 Packages Releases 37 Activity

Expose tls parameter of Go MySQL driver to config file #855

Merged
konrad merged 3 commits from kompetenzbolzen/api:main into main 2021-05-08 14:54:56 +00:00
Conversation 4 Commits 3 Files Changed 4 +13 -2
kompetenzbolzen commented 2021-05-08 14:28:35 +00:00
Contributor
Copy Link

Description

My MariaDB server is on a seperate Host and I would really like communication to be encrypted. This change exposes the tls parameter of the Go MySQL driver to the config file as database.tls.

Tested on Debian 10 and MariaDB 15.1 with TLS1.1

Checklist

  • I added or improved tests
  • I added or improved docs for my feature
    • Swagger (including mage do-the-swag)
    • Error codes
    • New config options (including adding them to config.yml.saml and running mage generate-docs)
# Description My MariaDB server is on a seperate Host and I would really like communication to be encrypted. This change exposes the `tls` parameter of the Go MySQL driver to the config file as `database.tls`. Tested on Debian 10 and MariaDB 15.1 with TLS1.1 # Checklist * [ ] I added or improved tests * [x] I added or improved docs for my feature * [ ] Swagger (including `mage do-the-swag`) * [ ] Error codes * [x] New config options (including adding them to `config.yml.saml` and running `mage generate-docs`)
kompetenzbolzen added 2 commits 2021-05-08 14:28:36 +00:00
Update docs for database.tls option
Some checks failed
continuous-integration/drone/pr Build is failing
Details
29b631108d
konrad approved these changes 2021-05-08 14:33:13 +00:00
konrad commented 2021-05-08 14:36:36 +00:00
Owner
Copy Link

Please fix the lint error, should be good to go then.

Please fix the lint error, should be good to go then.
kompetenzbolzen added 1 commit 2021-05-08 14:43:53 +00:00
fix lint: DatabaseTls -> DatabaseTLS
All checks were successful
continuous-integration/drone/pr Build is passing
Details
c7353191c5
kompetenzbolzen commented 2021-05-08 14:53:04 +00:00
Author
Contributor
Copy Link

damn, that was quick. thanks!

damn, that was quick. thanks!
konrad merged commit 86b7d224ab into main 2021-05-08 14:54:56 +00:00
konrad commented 2021-05-08 14:55:04 +00:00
Owner
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
konrad
Labels
Clear labels
dependencies
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
needs reproduction
question
More information is needed
security
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/vikunja#855
No description provided.
Delete Branch "kompetenzbolzen/api:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?