Add support of Unix socket #912

andreymal · 2021-07-07T22:18:19Z

andreymal commented

2021-07-07 22:18:19 +00:00

This may probably resolve #872, but the limitation is that this implementation doesn't allow both unix and tcp, not sure if @Dave will be happy with this

andreymal force-pushed main from 2bba00d132 to d3b79548c1

2021-07-07 22:26:28 +00:00

Compare

Dave commented

2021-07-08 00:24:20 +00:00

First-time contributor

I'm perfectly ok with that, first of all because you provided the code :D and secondly because the entire point of a unix domain socket is to avoid the TCP/IP stack in the first place. See this:

https://serverfault.com/questions/124517/what-is-the-difference-between-unix-sockets-and-tcp-ip-sockets

and look at Peter Green's decently formed answer to this question.

Thank you for this code.

I'm perfectly ok with that, first of all because you provided the code :D and secondly because the entire point of a unix domain socket is to avoid the TCP/IP stack in the first place. See this: https://serverfault.com/questions/124517/what-is-the-difference-between-unix-sockets-and-tcp-ip-sockets and look at Peter Green's decently formed answer to this question. Thank you for this code.

konrad approved these changes 2021-07-08 08:12:20 +00:00

konrad left a comment

Looks great!

I think we can merge this once the CI passes.

Thanks for the PR.

Looks great! I think we can merge this once the CI passes. Thanks for the PR.

konrad commented

2021-07-08 08:12:54 +00:00

Ah, looks like the CI passed but not in the commit from before. I'll merge this now.

konrad merged commit 50b49ffab6 into main

2021-07-08 08:13:02 +00:00

konrad referenced this issue from a commit