Make sure list / task favorites are set per user, not per entity #915

konrad · 2021-07-09T21:12:42Z

konrad commented

2021-07-09 21:12:42 +00:00

Description

This PR changes the way task/list favorites are saved internally: Previously, each entity had a is_favorite field in the db. If a user marked it as favorite, the field would contain true.
This has one big issue: Favorites are global - if one user of a shared lists marks that as favorite it is set to be favorite for everyone.

From now on, all favorite state is saved in a separate table and joined together when a user requests a list of lists/tasks.

Resolves vikunja/api#914

Checklist

Add a new test to make sure users only see their own favorites

# Description This PR changes the way task/list favorites are saved internally: Previously, each entity had a `is_favorite` field in the db. If a user marked it as favorite, the field would contain true. This has one big issue: Favorites are global - if one user of a shared lists marks that as favorite it is set to be favorite for everyone. From now on, all favorite state is saved in a separate table and joined together when a user requests a list of lists/tasks. Resolves https://kolaente.dev/vikunja/api/issues/914 # Checklist * [x] Add a new test to make sure users only see their own favorites

konrad added 11 commits 2021-07-09 21:12:43 +00:00

Move task favorites to new table f640db5663

Add returning favorites a8c6141a2c

Migrate existing favorites 0bb6ed98f5

Drop favorites column 821c97b764

Fix getting and setting favorites 29a6b395e4

Move setting list favorites 84184b16a5

Fix getting favorite tasks e13aa067ef

Make pseudo list of favorite tasks work again d06ee82769

Fix all favorite lists showing up in the pseudo namespace 09f21ac622

Generate swagger docs 6316af12d8

Fix lint