vikunja
/
vikunja
6
43
Fork 72
Code Issues 150 Pull Requests 19 Packages Releases 32 Activity

Make sure list / task favorites are set per user, not per entity #915

Merged
konrad merged 15 commits from fix/favorites into main 2021-07-10 10:21:54 +00:00
Conversation 0 Commits 15 Files Changed 16 +7 -5
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 09f21ac622 - Show all commits

12
pkg/models/namespace.go
View File

@ -547,6 +547,13 @@ func (n *Namespace) ReadAll(s *xorm.Session, a web.Auth, search string, page int
lists = append(lists, savedFiltersNamespace.Lists...)
}
/////////////////
// Add list details (favorite state, among other things
err = addListDetails(s, lists, a)
if err != nil {
return
}
/////////////////
// Favorite lists
@ -562,11 +569,6 @@ func (n *Namespace) ReadAll(s *xorm.Session, a web.Auth, search string, page int
//////////////////////
// Put it all together
err = addListDetails(s, lists, a)
if err != nil {
return
}
for _, list := range lists {
if list.NamespaceID == SharedListsPseudoNamespace.ID || list.NamespaceID == SavedFiltersPseudoNamespace.ID {
// Shared lists and filtered lists are already in the namespace