Erwan Martin zewaren
zewaren commented on pull request vikunja/vikunja#1634 2023-11-01 13:29:16 +00:00
feat(caldav): Add support for subtasks (i.e. RELATED-TO property) in CalDAV

I added that logic initially from personal experience.

When I had some network errors with some buggy clients, I was able to end up with task trees being pushed in the wrong order.

It really…

zewaren commented on pull request vikunja/vikunja#1442 2023-10-30 08:13:03 +00:00
WIP: feat(caldav): Add support for subtasks in CalDAV.

Hey @mayanez

Thanks for the addition! I've checked the diff between our branches and I'm good with everything.

I've been running my branch for a month now on DAVx5 & Tasks on Android as…

zewaren closed pull request vikunja/vikunja#1442 2023-10-30 08:13:03 +00:00
WIP: feat(caldav): Add support for subtasks in CalDAV.
zewaren pushed to feature/caldav-subtasks at zewaren/api 2023-10-29 21:01:39 +00:00
cbae9b7a87 Lint
zewaren pushed to feature/caldav-subtasks at zewaren/api 2023-10-29 20:17:30 +00:00
0ae46aa363 Fix the bucket tests since we moved a task.
5313730752 Add unit tests for the CALDAV subtask feature.
2ae966c0ad Merge branch 'main' into feature/caldav-subtasks
66afe52afb fix(deps): update module xorm.io/xorm to v1.3.4 (#1630)
f5e5b22641 chore(deps): update lockfile
Compare 99 commits »
zewaren pushed to feature/caldav-subtasks at zewaren/api 2023-09-17 17:53:34 +00:00
49481ad80f fix(caldav): remove duplicate logic.
fbaf2c182d Merge branch 'main' into feature/caldav-subtasks
f065dcf4ad fix(typesense): add typesense sync to initial structs
addcbdd8ca fix(test): don't check for error
054f21821c fix(typesense): don't try to index tasks if there are none
Compare 42 commits »
zewaren commented on pull request vikunja/vikunja#1605 2023-09-17 16:56:35 +00:00
fix(caldav): do not update dates of tasks when repositioning them

Comment added 👍

zewaren commented on pull request vikunja/vikunja#1605 2023-09-17 16:47:06 +00:00
fix(caldav): do not update dates of tasks when repositioning them

Looks good overall, but this won't prevent changed etags of tasks which are dragged via the kanban board or task list. Only when the position of all tasks in a bucket/project are recalculated.

zewaren pushed to fix/caldav-etag-dates at zewaren/api 2023-09-17 16:42:20 +00:00
49a790fdad fix(docs): explain why we use NoAutoTime().
zewaren created pull request vikunja/vikunja#1605 2023-09-17 15:35:53 +00:00
fix(caldav): do not update dates of tasks when repositioning them
zewaren created branch fix/caldav-etag-dates in zewaren/api 2023-09-17 15:35:22 +00:00
zewaren pushed to fix/caldav-etag-dates at zewaren/api 2023-09-17 15:35:22 +00:00
4f55099896 fix(caldav): do not update dates of tasks when repositioning them
f065dcf4ad fix(typesense): add typesense sync to initial structs
addcbdd8ca fix(test): don't check for error
054f21821c fix(typesense): don't try to index tasks if there are none
38a3a5c6e8 fix(typesense): explicitely create typesense sync table
Compare 10 commits »
zewaren pushed to feature/caldav-subtasks at zewaren/api 2023-09-10 15:45:41 +00:00
24773ad6b7 Fix the tests after bumping to master.
a0cf4cf8a8 Add missing parameter.
3865219e6e Merge branch 'main' into feature/caldav-subtasks
97b5cd306f feat: add demo mode flag
b3a847e581 fix(kanban): create missing kanban buckets (#1601)
Compare 279 commits »
zewaren commented on pull request vikunja/vikunja#1442 2023-09-10 15:44:37 +00:00
WIP: feat(caldav): Add support for subtasks in CalDAV.

Do you know any CALDAV TODO list client/app that supports multiple parents for tasks? I'd be possible to support them here, but would it make any sense for anyone at all?

zewaren commented on pull request vikunja/vikunja#1442 2023-09-10 15:43:09 +00:00
WIP: feat(caldav): Add support for subtasks in CalDAV.

So, the way the test infrastructure is currently configured on the main branch is that every HTTP request resets the database by loading all the fixtures.

This prevents us from being able to…

zewaren commented on pull request vikunja/vikunja#1442 2023-09-10 15:37:48 +00:00
WIP: feat(caldav): Add support for subtasks in CalDAV.

Here "legacy" means that the tasks had a parent, but that parent is gone.

This case is when a CALDAV client removes the parent relationship and pushes the task to us. We still have the…

zewaren commented on pull request vikunja/vikunja#1442 2023-09-10 15:36:03 +00:00
WIP: feat(caldav): Add support for subtasks in CalDAV.

This test file only tests parsing CALDAV entries. It doesn't touch the database at all. We don't really care if the relation actually exists. We only care that the field was parsed into the…

zewaren commented on pull request vikunja/vikunja#1442 2023-08-03 14:02:29 +00:00
WIP: feat(caldav): Add support for subtasks in CalDAV.

Hey. Sorry, I've been super busy the last few months. I can fix it in a few weeks, if that's ok. Erwan.

zewaren pushed to feature/caldav-subtasks at zewaren/api 2023-03-22 21:11:54 +00:00
f9040b402d fix: lint
zewaren pushed to feature/caldav-subtasks at zewaren/api 2023-03-22 20:20:10 +00:00
a1f25d3671 fix: Typo in a comment