danstewart
0 Followers · 0 Following
Repositories
1
 Projects Packages Code Public Activity Starred Repositories
2
danstewart deleted branch danstewart/fix-menu-auto-collapse-mobile from danstewart/vikunja-frontend 2023-03-07 15:58:00 +00:00
danstewart commented on pull request vikunja/frontend#3194 2023-03-07 15:57:54 +00:00
fix: collapse menu on mobile when path changes

Thanks 🙂

danstewart created pull request vikunja/frontend#3194 2023-03-05 17:26:28 +00:00
fix: collapse menu on mobile when path changes
87d7b4e17a fix: collapse menu on mobile when path changes
danstewart pushed to main at danstewart/vikunja-frontend 2023-03-05 17:00:28 +00:00
7b6f76d1b4 fix: stop revealing elements on hover if hover is not supported (#3191)
ad0029789d chore(deps): update dependency esbuild to v0.17.11
e13f57c30a chore(deps): update dependency @types/node to v18.14.6
Compare 3 commits »
danstewart commented on pull request vikunja/frontend#3191 2023-03-04 15:35:23 +00:00
fix: stop revealing elements on hover if hover is not supported

Addressed those last two comments. 🙂

danstewart pushed to danstewart/fix-ios-double-tap at danstewart/vikunja-frontend 2023-03-04 15:34:44 +00:00
79ed7bf6ce fix: combine rules
danstewart commented on pull request vikunja/frontend#3191 2023-03-03 22:23:37 +00:00
fix: stop revealing elements on hover if hover is not supported

Sorry, I was being dumb.

Should be sorted now - thank you.

danstewart pushed to danstewart/fix-ios-double-tap at danstewart/vikunja-frontend 2023-03-03 22:18:26 +00:00
a4656b7f90 fix: always show is-favorite items
danstewart commented on pull request vikunja/frontend#3191 2023-03-03 21:57:35 +00:00
fix: stop revealing elements on hover if hover is not supported

@konrad Odd, it works fine for me 🤔

Which browser and device are you using? I've tried on Chrome and Firefox.

danstewart commented on pull request vikunja/frontend#3191 2023-03-03 21:30:32 +00:00
fix: stop revealing elements on hover if hover is not supported

Good catch, I was duplicating a few rules as I kept the original opacity: 0 then immediately set it back to opacity: 1.

I've removed the duplicates now.

danstewart pushed to danstewart/fix-ios-double-tap at danstewart/vikunja-frontend 2023-03-03 21:29:50 +00:00
fe7cbfdc14 fix: reduce duplicate CSS rules
danstewart commented on pull request vikunja/frontend#3191 2023-03-03 21:09:35 +00:00
fix: stop revealing elements on hover if hover is not supported

Pretty good: https://caniuse.com/css-media-interaction

danstewart created pull request vikunja/frontend#3191 2023-03-03 18:00:39 +00:00
fix: stop revealing elements on hover if hover is not supported
danstewart created branch danstewart/fix-ios-double-tap in danstewart/vikunja-frontend 2023-03-03 17:58:15 +00:00
danstewart pushed to danstewart/fix-ios-double-tap at danstewart/vikunja-frontend 2023-03-03 17:58:15 +00:00
da7ddbde27 fix: stop revealing elements on hover if hover is not supported
danstewart created repository danstewart/vikunja-frontend 2023-03-03 17:28:31 +00:00
danstewart commented on issue vikunja/frontend#3162 2023-02-27 15:53:41 +00:00
<500 when get issue>

Looks like for iPads with the apple pencil the hover check would be false then we would just show the star and overflow menu button, which seems fine to me.

Alternatively we could remove the…

danstewart commented on issue vikunja/frontend#3162 2023-02-27 10:02:08 +00:00
<500 when get issue>

It's not intentional.

Great, I'll submit a fix when I get some time.

Looks like the issue is because the star button is shown on hover. Was thinking on mobile it should just always be…