fix: collapse menu on mobile when path changes #3194

Merged

dpschen merged 1 commits from danstewart/vikunja-frontend:danstewart/fix-menu-auto-collapse-mobile into main 2023-03-07 15:56:12 +00:00

Conversation 4 Commits 1 Files Changed 1 +7 -2

danstewart commented 2023-03-05 17:26:25 +00:00

Contributor

Copy Link

When tapping an item in the menu on 0.20.3 on mobile it currently collapses the menu, this no longer happens on main.

Looks like this was dropped here:
c502f9b840

When tapping an item in the menu on 0.20.3 on mobile it currently collapses the menu, this no longer happens on `main`. Looks like this was dropped here: https://kolaente.dev/vikunja/frontend/commit/c502f9b840ee2d65193aa4ef29c7f260b49db0d2

danstewart added 1 commit 2023-03-05 17:26:28 +00:00

87d7b4e17a fix: collapse menu on mobile when path changes

danstewart requested review from dpschen 2023-03-05 17:27:17 +00:00

frederick commented 2023-03-05 17:30:03 +00:00

Member

Copy Link

Hi danstewart!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3194-danstewart-fix-menu-auto-collaps--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi danstewart! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3194-danstewart-fix-menu-auto-collaps--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad commented 2023-03-05 17:47:54 +00:00

Owner

Copy Link

@dpschen was that intentional?

@dpschen was that intentional?

dpschen commented 2023-03-07 15:55:17 +00:00

Member

Copy Link

@dpschen was that intentional?

This was not intentional, good catch!

When I was refactoring this I didn't remember what exactly I meant by the original comment

// hide menu on mobile

The new comment makes it much clearer now!

> @dpschen was that intentional? This was not intentional, good catch! When I was refactoring this I didn't remember what exactly I meant by the original comment ``` // hide menu on mobile ``` The new comment makes it much clearer now!

👍 1

dpschen approved these changes 2023-03-07 15:56:03 +00:00

dpschen merged commit 1b06112db4 into main 2023-03-07 15:56:12 +00:00

danstewart commented 2023-03-07 15:57:54 +00:00

Author

Contributor

Copy Link

Thanks 🙂

Thanks 🙂

🎉 1

danstewart deleted branch danstewart/fix-menu-auto-collapse-mobile 2023-03-07 15:58:00 +00:00

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

dpschen

Labels

Clear labels   

area/internal-code

  

changes requested

  

confirmed

  

dependencies

  

duplicate

This issue or pull request already exists

  

good first issue

  

help wanted

Need some help

  

hosting

  

invalid

Something is wrong

  

kind/bug

Something is not working

  

kind/feature

New feature

  

question

More information is needed

  

wontfix

This won't be fixed

No Label

area/internal-code

changes requested

confirmed

dependencies

duplicate

good first issue

help wanted

hosting

invalid

kind/bug

kind/feature

question

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

4 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3194

No description provided.