vikunja
/
desktop
Archived
2
3
Fork 2
Code Issues 7 Pull Requests 1 Releases 2 Wiki Activity

Migrate Vikunja from electron to tauri #127

Open
CL0Pinette wants to merge 6 commits from CL0Pinette/desktop:migrate_to_tauri into main
pull from: CL0Pinette/desktop:migrate_to_tauri
merge into: vikunja:main
Conversation 3 Commits 6 Files Changed 32 +4298 -2191
CL0Pinette commented 2022-11-07 08:42:47 +00:00
First-time contributor
Copy Link

Here is my POC for the migration from electron to tauri. Don't hesitate to tell me if there are things to improve

Tested on

  • Windows
  • Linux x86_64
  • Linux aarch64
  • Darwin x86_64
  • Darwin aarch64
Here is my POC for the migration from electron to tauri. Don't hesitate to tell me if there are things to improve #### Tested on - [ ] Windows - [ ] Linux x86_64 - [ ] Linux aarch64 - [ ] Darwin x86_64 - [x] Darwin aarch64
CL0Pinette added 1 commit 2022-11-07 08:42:48 +00:00
konrad added 1 commit 2022-11-07 14:51:13 +00:00
konrad reviewed 2022-11-07 14:53:17 +00:00
konrad left a comment
Owner

Already looks great! I don't know anything about rust, maybe some of my comments are redundant.

Already looks great! I don't know anything about rust, maybe some of my comments are redundant.
src-tauri/Cargo.toml Outdated
@ -0,0 +1,32 @@
[package]
name = "app"
konrad commented 2022-11-07 14:51:54 +00:00
Owner

What should the value of this be?

What should the value of this be?
CL0Pinette commented 2022-11-10 07:30:25 +00:00
Author
First-time contributor

The Cargo.yml declares dependencies and the package itself when we use it with another rust package for example. We sure can change the values in the package section to whatever we want :

  • name
  • licence
  • version
  • year
    ...
The Cargo.yml declares dependencies and the package itself when we use it with another rust package for example. We sure can change the values in the `package` section to whatever we want : - name - licence - version - year ...
👍 1
src-tauri/Cargo.toml Outdated
@ -0,0 +1,32 @@
[package]
name = "app"
version = "0.1.0"
konrad commented 2022-11-07 14:52:06 +00:00
Owner

Can we set this dynamically in ci?

Can we set this dynamically in ci?
src-tauri/Cargo.toml
@ -0,0 +6,4 @@
license = ""
repository = ""
default-run = "app"
edition = "2021"
konrad commented 2022-11-07 14:52:22 +00:00
Owner

Is this a configurable value?

Is this a configurable value?
CL0Pinette commented 2022-11-10 07:33:19 +00:00
Author
First-time contributor

The default-run value should be the same as the package name because it is this package that needs to be run on start

The `default-run` value should be the same as the package name because it is this package that needs to be run on start
👍 1
konrad added 1 commit 2022-11-07 14:58:36 +00:00
konrad commented 2022-11-11 12:37:24 +00:00
Owner
Copy Link

I wonder if this will work when using openid auth?

I wonder if this will work when using openid auth?
konrad added 1 commit 2022-11-13 14:09:35 +00:00
konrad commented 2022-11-13 15:33:07 +00:00
Owner
Copy Link

Did some testing and digging, looks like more work is required to get this working with openid. The main problem is most openid providers don't support protocols (like tauri://localhost) as a redirect target.

https://github.com/tauri-apps/tauri/discussions/5251
https://github.com/tauri-apps/tauri/discussions/3020

Seems like the simplest solution would be tauri-plugin-localhost.

Did some testing and digging, looks like more work is required to get this working with openid. The main problem is most openid providers don't support protocols (like `tauri://localhost`) as a redirect target. https://github.com/tauri-apps/tauri/discussions/5251 https://github.com/tauri-apps/tauri/discussions/3020 Seems like the simplest solution would be [`tauri-plugin-localhost`](https://lib.rs/crates/tauri-plugin-localhost).
konrad added 2 commits 2022-11-13 15:34:45 +00:00
RaptaG commented 2023-07-10 16:28:00 +00:00
First-time contributor
Copy Link

If (I hope when) this is merged, we'll need to update the Flathub build

If (I hope when) this is merged, we'll need to update the Flathub build
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
blocked by upstream

   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
kind/feature

New feature

  
kind/ux

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
blocked by upstream
bug
duplicate
help wanted
invalid
kind/feature
kind/ux
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/desktop#127
No description provided.
Delete Branch "CL0Pinette/desktop:migrate_to_tauri"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?