vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: kanban card spacing #1005

Merged
konrad merged 2 commits from fix/kanban-card-spacing into main 2021-11-16 21:44:07 +00:00
Conversation 4 Commits 2 Files Changed 7 +10 -18
konrad commented 2021-11-14 21:17:17 +00:00
Owner
Copy Link

Before:

image

After:

image

Before: ![image](/attachments/90caf5dd-e014-4efc-8606-f03b9b0fb2d6) After: ![image](/attachments/3d85e39d-89b1-4dff-a242-758cfcb6375a)
image.png
33 KiB
image.png
26 KiB
konrad commented 2021-11-14 21:18:14 +00:00
Author
Owner
Copy Link

The styles get overridden in styles/components/tassk.scss - not sure if fixing it with an !important is the best way to solve it, but certainly the easiest.

The styles get overridden in `styles/components/tassk.scss` - not sure if fixing it with an `!important` is the best way to solve it, but certainly the easiest.
konrad requested review from dpschen 2021-11-14 21:18:22 +00:00
frederick commented 2021-11-14 21:51:19 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1005-fixkanban-card-spacing--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1005-fixkanban-card-spacing--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen commented 2021-11-15 15:05:15 +00:00
Member
Copy Link

How about this: 3945fe84d1

How about this: https://kolaente.dev/dpschen/frontend/commit/3945fe84d1d3083a670f552c163d6860b204068e
konrad force-pushed fix/kanban-card-spacing from 2ef8036829 to 4164500997 2021-11-16 21:18:30 +00:00 Compare
konrad commented 2021-11-16 21:19:14 +00:00
Author
Owner
Copy Link

@dpschen That looks like a proper fix. Cherry-picked, will merge when CI passes.

@dpschen That looks like a proper fix. Cherry-picked, will merge when CI passes.
👍 1
konrad merged commit ae5d3ecac5 into main 2021-11-16 21:44:07 +00:00
konrad deleted branch fix/kanban-card-spacing 2021-11-16 21:44:07 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1005
No description provided.
Delete Branch "fix/kanban-card-spacing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?