vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/bulma-css-variables-reduce-import-size #1023

Merged
konrad merged 1 commits from dpschen/frontend:feature/bulma-css-variables-reduce-import-size into main 2021-11-23 07:09:18 +00:00
Conversation 2 Commits 1 Files Changed 1 +79 -10
dpschen commented 2021-11-17 14:17:11 +00:00
Member
Copy Link

Depends on #954

Depends on https://kolaente.dev/vikunja/frontend/pulls/954
dpschen added 67 commits 2021-11-17 14:17:11 +00:00
continuous-integration/drone/pr Build is passing Details
2a65126a80 No need to use opacity of 1
continuous-integration/drone/pr Build is passing Details
aff7a1f2ea Removed unused sass variable -invert
continuous-integration/drone/pr Build is passing Details
b39a699d58 Change dark mode white to a grey looks better
continuous-integration/drone/pr Build is passing Details
1c90178e5e Fix #2 - modal close button not visible
continuous-integration/drone/pr Build is passing Details
f5f00bf46e Remove important declarations that are no longer needed
continuous-integration/drone/pr Build is passing Details
6877ca30a1 Move dark color for modal close icon into scoped styles
continuous-integration/drone/pr Build is passing Details
a45c6cdf6b Rename light-background variable to site-background
continuous-integration/drone/pr Build is passing Details
0e93ddf4b5 Move colors.scss include into global.scss
continuous-integration/drone/pr Build is passing Details
749749db9a
chore: yarn install after merge with main
87064f1578
Merge branch 'main' into bulma-css-variables 
# Conflicts:
#	src/components/home/contentLinkShare.vue
#	src/components/home/contentNoAuth.vue
#	src/styles/theme/navigation.scss
continuous-integration/drone/pr Build is failing Details
1745c174e1
chore: yarn install after merge with main
2614fddf51
Merge branch 'main' into bulma-css-variables 
# Conflicts:
#	src/App.vue
#	src/components/home/contentNoAuth.vue
#	src/components/home/topNavigation.vue
#	src/components/misc/api-config.vue
#	src/components/tasks/partials/relatedTasks.vue
continuous-integration/drone/pr Build is passing Details
f08a68594e Move merged sass vars to css vars
continuous-integration/drone/pr Build is passing Details
faa3c3b156 Set logo text to currentColor
continuous-integration/drone/pr Build is passing Details
a957df0a59 Set logo text color in light and dark mode
continuous-integration/drone/pr Build is failing Details
f11eeb6dce Fix embeded logo inheriting bulma navbar hover styles
continuous-integration/drone/pr Build is passing Details
3bd3165032 Fix tag color in dark mode
continuous-integration/drone/pr Build is passing Details
2c695ef03a Remove conflicts accidentaly committed.
continuous-integration/drone/pr Build is passing Details
d7c592d6ab Fix for table row text not visible on hover
continuous-integration/drone/pr Build is passing Details
7e064053f9 Fix poor readability of dropdown menu items
continuous-integration/drone/pr Build is passing Details
595a5e8145 Make dark mode shadows visible.
continuous-integration/drone/pr Build is passing Details
f1ecf6d897 Still visible but better color shadows
continuous-integration/drone/pr Build is passing Details
05cf268dd8 Typo fix.
continuous-integration/drone/pr Build is failing Details
359a6b17d9 Make tertary buttons useable
continuous-integration/drone/pr Build is failing Details
d923a73827 fix: hack by using color definitions behind variables
continuous-integration/drone/pr Build is failing Details
5d78cd5b9c Fix build error due to missed dependency during manual resolution of 
upstream merge conflict
dpschen added a new dependency 2021-11-17 14:17:51 +00:00
#954 Migrate to bulma-css-variables and introduce dark mode
frederick commented 2021-11-17 14:23:30 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1023-featurebulma-css-variables-reduce-import-size--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1023-featurebulma-css-variables-reduce-import-size--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/bulma-css-variables-reduce-import-size from 26de34e7a6 to e54b61e550 2021-11-22 21:37:38 +00:00 Compare
dpschen changed title from WIP: feature/bulma-css-variables-reduce-import-size to feature/bulma-css-variables-reduce-import-size 2021-11-22 21:37:51 +00:00
dpschen requested review from konrad 2021-11-22 21:38:05 +00:00
konrad was assigned by dpschen 2021-11-22 21:38:10 +00:00
konrad approved these changes 2021-11-22 21:49:08 +00:00
konrad commented 2021-11-22 22:11:10 +00:00
Owner
Copy Link

Looking good, feel free to merge when the CI passes.

Looking good, feel free to merge when the CI passes.
🎉 1
konrad merged commit b688f35446 into main 2021-11-23 07:09:18 +00:00
konrad deleted branch feature/bulma-css-variables-reduce-import-size 2021-11-23 07:09:18 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#954 Migrate to bulma-css-variables and introduce dark mode
vikunja/frontend
Reference: vikunja/frontend#1023
No description provided.
Delete Branch "dpschen/frontend:feature/bulma-css-variables-reduce-import-size"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?