vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: use popper.js v2 vue3 version of v-tooltip #1038

Merged
konrad merged 1 commits from dpschen/frontend:feature/use-vue3-v-tooltip into main 2021-11-23 07:08:22 +00:00
Conversation 4 Commits 1 Files Changed 5 +34 -127
dpschen commented 2021-11-19 13:11:17 +00:00
Member
Copy Link
No description provided.
frederick commented 2021-11-19 13:28:58 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1038-featureuse-vue3-v-tooltip--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1038-featureuse-vue3-v-tooltip--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad was assigned by dpschen 2021-11-21 12:51:01 +00:00
dpschen requested review from konrad 2021-11-21 12:51:04 +00:00
konrad requested changes 2021-11-22 18:27:36 +00:00
konrad left a comment
Owner

Could you add some styling to make the tooltip a bit smaller? (like the old one was)

I think it is too large right now:

image

Could you add some styling to make the tooltip a bit smaller? (like the old one was) I think it is too large right now: ![image](/attachments/7af19301-48c3-4764-992f-3433f2ad6153)
image.png
16 KiB
dpschen force-pushed feature/use-vue3-v-tooltip from 66ade08e98 to 60a4a52835 2021-11-22 21:06:21 +00:00 Compare
konrad commented 2021-11-22 21:18:55 +00:00
Owner
Copy Link

Conflicts :)

Conflicts :)
👍 1
dpschen force-pushed feature/use-vue3-v-tooltip from 60a4a52835 to ae65ea738a 2021-11-22 21:31:37 +00:00 Compare
konrad commented 2021-11-22 21:37:03 +00:00
Owner
Copy Link

Aaaaaaannd conflicts again 😀

Looks like there's too many things happening right now

Aaaaaaannd conflicts again 😀 Looks like there's too many things happening right now
dpschen force-pushed feature/use-vue3-v-tooltip from ae65ea738a to d3875240c9 2021-11-22 21:51:08 +00:00 Compare
konrad approved these changes 2021-11-22 21:55:21 +00:00
konrad commented 2021-11-22 22:10:53 +00:00
Owner
Copy Link

Looking good, feel free to merge when the CI passes.

Looking good, feel free to merge when the CI passes.
🎉 1
konrad merged commit 91580f97a1 into main 2021-11-23 07:08:22 +00:00
konrad deleted branch feature/use-vue3-v-tooltip 2021-11-23 07:08:22 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1038
No description provided.
Delete Branch "dpschen/frontend:feature/use-vue3-v-tooltip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?