feat: improve namespace explanation #1040

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-improve-namespace-explanation into main 2021-11-22 18:41:01 +00:00
Member
No description provided.
dpschen added 1 commit 2021-11-19 13:16:33 +00:00
continuous-integration/drone/pr Build is passing Details
bf048b8a41
feat: improve namespace explanation
dpschen reviewed 2021-11-19 13:17:31 +00:00
@ -39,1 +34,3 @@
</p>
<div class="notification is-info mt-4">
<h4 class="title">{{ $t('namespace.create.tooltip') }}</h4>
Author
Member

Maybe a good reminder to name translation ids by function and not by where they are used.
(Not sure if I should fix this)

Maybe a good reminder to name translation ids by function and not by where they are used. (Not sure if I should fix this)

I think that's a good idea. I'm a bit hesitant to change them because that would invalidate all existing translations. We should keep this in mind for new strings at least, maybe something to change everyhwere at some point.

I think that's a good idea. I'm a bit hesitant to change them because that would invalidate all existing translations. We should keep this in mind for new strings at least, maybe something to change everyhwere at some point.
Author
Member

Isn't there a way to rename translation ids and notify crowdin?

Isn't there a way to rename translation ids and notify crowdin?

You can't tell it "hey the key for this string has been renamed" but you can kind of restore the old translation from the translation memory. That's a manual process though and has to be done for each language.

You can't tell it "hey the key for this string has been renamed" but you can kind of restore the old translation from the translation memory. That's a manual process though and has to be done for each language.
Author
Member

That's annoying :/

Will maybe look into this some time :D

That's annoying :/ Will maybe look into this some time :D
konrad marked this conversation as resolved
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1040-featurefeat-improve-namespace-explanation--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1040-featurefeat-improve-namespace-explanation--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen requested review from konrad 2021-11-21 12:50:20 +00:00
konrad was assigned by dpschen 2021-11-21 12:50:22 +00:00
konrad approved these changes 2021-11-22 18:40:55 +00:00
konrad merged commit ae36c041a7 into main 2021-11-22 18:41:01 +00:00
konrad deleted branch feature/feat-improve-namespace-explanation 2021-11-22 18:41:01 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.