vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: convert simple components to script setup and use typescript #1120

Merged
konrad merged 1 commits from dpschen/frontend:feature/typescript-and-script-setup-for-simple-components into main 2021-12-04 14:47:33 +00:00
Conversation 5 Commits 1 Files Changed 16 +298 -387
dpschen commented 2021-11-30 13:29:45 +00:00
Member
Copy Link
No description provided.
dpschen force-pushed feature/typescript-and-script-setup-for-simple-components from 8f47ca123b to da44a5aaf1 2021-11-30 13:34:40 +00:00 Compare
dpschen force-pushed feature/typescript-and-script-setup-for-simple-components from da44a5aaf1 to c2e5514af3 2021-11-30 13:35:47 +00:00 Compare
dpschen force-pushed feature/typescript-and-script-setup-for-simple-components from c2e5514af3 to b6d7d48bb6 2021-11-30 17:06:08 +00:00 Compare
frederick commented 2021-11-30 17:10:35 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1120-featuretypescript-and-script-setup-for-simple-components--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1120-featuretypescript-and-script-setup-for-simple-components--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/typescript-and-script-setup-for-simple-components from b6d7d48bb6 to 513f4af48d 2021-11-30 23:40:33 +00:00 Compare
dpschen changed title from WIP: feat: convert simple components to script setup and use typescript to feat: convert simple components to script setup and use typescript 2021-12-02 22:17:32 +00:00
dpschen requested review from konrad 2021-12-02 22:17:39 +00:00
konrad was assigned by dpschen 2021-12-02 22:17:43 +00:00
konrad requested changes 2021-12-04 14:05:38 +00:00
konrad left a comment
Owner

Please fix the typo, looking very good otherwise!

Please fix the typo, looking very good otherwise!
src/components/misc/Done.vue Outdated
@ -18,1 +11,3 @@
name: 'Done',
<script lang="ts" setup>
import {PropType} from 'vue'
type Vartiants = 'default' | 'small'
konrad commented 2021-12-04 14:02:01 +00:00
Owner

Typo: Should be Variants

Typo: Should be `Variants`
dpschen commented 2021-12-04 14:33:26 +00:00
Author
Member

Done

Done
dpschen marked this conversation as resolved
konrad removed their assignment 2021-12-04 14:25:28 +00:00
dpschen was assigned by konrad 2021-12-04 14:25:29 +00:00
dpschen force-pushed feature/typescript-and-script-setup-for-simple-components from 513f4af48d to 6c832560ed 2021-12-04 14:33:33 +00:00 Compare
dpschen requested review from konrad 2021-12-04 14:33:38 +00:00
konrad commented 2021-12-04 14:33:55 +00:00
Owner
Copy Link

Now there's conflicts :/

Now there's conflicts :/
😆 1
konrad approved these changes 2021-12-04 14:34:27 +00:00
konrad left a comment
Owner

Feel free to merge when the conflicts are resolved.

Feel free to merge when the conflicts are resolved.
dpschen force-pushed feature/typescript-and-script-setup-for-simple-components from 6c832560ed to b3a1fe0cad 2021-12-04 14:34:51 +00:00 Compare
dpschen commented 2021-12-04 14:35:03 +00:00
Author
Member
Copy Link

Now there's conflicts :/

Solved

> Now there's conflicts :/ Solved
dpschen commented 2021-12-04 14:35:53 +00:00
Author
Member
Copy Link

@konrad I can't merge because of missing approval

@konrad I can't merge because of missing approval
konrad approved these changes 2021-12-04 14:37:13 +00:00
konrad merged commit ac630ac775 into main 2021-12-04 14:47:33 +00:00
konrad deleted branch feature/typescript-and-script-setup-for-simple-components 2021-12-04 14:47:33 +00:00
dpschen commented 2021-12-04 15:20:18 +00:00
Author
Member
Copy Link

🥳

🥳
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
dpschen
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1120
No description provided.
Delete Branch "dpschen/frontend:feature/typescript-and-script-setup-for-simple-components"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?