vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Docker multistage build #113

Merged
konrad merged 2 commits from jonastheis/frontend:feat/docker-multistage-build into master 2020-04-19 17:27:16 +00:00
Conversation 1 Commits 2 Files Changed 1 +17 -4
jonastheis commented 2020-04-19 12:39:11 +00:00
Contributor
Copy Link

Solves #110.

Adds a Docker multistage build so that the image can be built without any dependencies on the host system except Docker.

Solves #110. Adds a Docker multistage build so that the image can be built without any dependencies on the host system except Docker.
konrad reviewed 2020-04-19 12:51:48 +00:00
Dockerfile Outdated
@ -2,0 +5,4 @@
COPY . ./
RUN yarn install
konrad commented 2020-04-19 12:51:48 +00:00
Owner

This should use yarn install --frozen-lockfile to take the dependencies from the lockfile and not modify the accidentially.

This should use `yarn install --frozen-lockfile` to take the dependencies from the lockfile and not modify the accidentially.
jonastheis commented 2020-04-19 13:39:37 +00:00
Author
Contributor

I'm not a frontend guy and just copied the command.

Fixed with the latest commit.

I'm not a frontend guy and just copied the command. Fixed with the latest commit.
konrad closed this pull request 2020-04-19 17:27:16 +00:00
konrad commented 2020-04-19 17:27:22 +00:00
Owner
Copy Link

Thanks!

Thanks!
konrad deleted branch feat/docker-multistage-build 2020-04-19 17:27:25 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#113
No description provided.
Delete Branch "jonastheis/frontend:feat/docker-multistage-build"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?