fix: flatpickr date not updating #1336

konrad · 2022-01-08T14:22:29Z

konrad commented

2022-01-08 14:22:29 +00:00

Fixes https://github.com/go-vikunja/api/issues/16

konrad added 1 commit 2022-01-08 14:22:30 +00:00

continuous-integration/drone/pr Build is passing Details

9af46a0154

fix: flatpickr date not updating

Fixes https://github.com/go-vikunja/api/issues/16

frederick commented

2022-01-08 14:26:58 +00:00

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1336-fixflatpickr-date-not-updating--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1336-fixflatpickr-date-not-updating--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen commented

2022-01-09 09:48:04 +00:00

approve

**approve**

konrad merged commit 6080e49f26 into main

2022-01-09 10:17:19 +00:00

konrad deleted branch fix/flatpickr-date-not-updating

2022-01-09 10:17:19 +00:00

konrad referenced this issue from a commit

2022-01-09 10:17:19 +00:00

fix: flatpickr date not updating (#1336)

dpschen reviewed 2022-01-19 21:01:35 +00:00

src/components/input/datepicker.vue

						
				@ -186,0 +178,4 @@

						// Since flatpickr dates are strings, we need to convert them to native date objects.

						// To make that work, we need a separate variable since flatpickr does not have a change event.

						flatPickrDate: {

							set(newValue) {

dpschen commented

2022-01-19 21:01:35 +00:00

Not sure: doesn't it make sense to merge this with modelValue / setDateValue?

Not sure: doesn't it make sense to merge this with `modelValue` / `setDateValue`?

konrad commented

2022-01-19 21:28:39 +00:00

The problem is iirc the conversion between the two. Flatpickr always returns a string but we want to return a date object. It would probably be doable to merge it, but this was easier.

👍 1

dpschen marked this conversation as resolved

This repo is archived. You cannot comment on pull requests.

No reviewers