fix: editor color in dark mode #1338

Merged

konrad merged 1 commits from fix/editor-color into main 2022-01-09 10:16:13 +00:00

Conversation 3 Commits 1 Files Changed 2 +34 -26

konrad commented 2022-01-08 16:46:19 +00:00

Owner

Copy Link

This PR fixes the editor colors in dark mode. It bothered me enough to finally fix it :)
The implementation is probably only "good enough" as we'll replace the editor anyway in the future.

Before:

After:

This PR fixes the editor colors in dark mode. It bothered me enough to finally fix it :) The implementation is probably only "good enough" as we'll replace the editor anyway in the future. Before:  After: 

image.png

14 KiB

image.png

14 KiB

konrad added 1 commit 2022-01-08 16:46:19 +00:00

ea6a61d5ea

fix: editor color in dark mode

konrad requested review from dpschen 2022-01-08 16:46:35 +00:00

frederick commented 2022-01-08 16:51:32 +00:00

Member

Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1338-fixeditor-color--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1338-fixeditor-color--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen commented 2022-01-09 09:45:04 +00:00

Member

Copy Link

Approve (cannot click that button on mobile (outside of viewport)

Do we want to use the inlined icons for the future editor aswell? if yes we should move them to external and load them as strings (we can do that with our loader).

**Approve** (cannot click that button on mobile (outside of viewport) Do we want to use the inlined icons for the future editor aswell? if yes we should move them to external and load them as strings (we can do that with our loader).

konrad merged commit 76fe2ceac6 into main 2022-01-09 10:16:13 +00:00

konrad deleted branch fix/editor-color 2022-01-09 10:16:14 +00:00

konrad referenced this issue from a commit 2022-01-09 10:16:14 +00:00

fix: editor color in dark mode (#1338)

konrad commented 2022-01-09 10:16:52 +00:00

Author

Owner

Copy Link

Do we want to use the inlined icons for the future editor aswell? if yes we should move them to external and load them as strings (we can do that with our loader).

Sure why not? Let's do that when we switch the editor.

> Do we want to use the inlined icons for the future editor aswell? if yes we should move them to external and load them as strings (we can do that with our loader). Sure why not? Let's do that when we switch the editor.

👍 1

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

dpschen

Labels

Clear labels   

area/internal-code

  

changes requested

  

confirmed

  

dependencies

  

duplicate

This issue or pull request already exists

  

good first issue

  

help wanted

Need some help

  

hosting

  

invalid

Something is wrong

  

kind/bug

Something is not working

  

kind/feature

New feature

  

question

More information is needed

  

wontfix

This won't be fixed

No Label

area/internal-code

changes requested

confirmed

dependencies

duplicate

good first issue

help wanted

hosting

invalid

kind/bug

kind/feature

question

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1338

No description provided.