feat: add remember me style login #1339

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1339-featurelong-tokens--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen reviewed 2022-02-05 18:20:08 +00:00

src/store/modules/auth.js Outdated

						
				@ -93,6 +93,7 @@ export default {

							const data = {

								username: credentials.username,

								password: credentials.password,

								long_token: credentials.longToken,

dpschen commented

2022-01-09 09:40:29 +00:00

Why dont we simply convert credentials to snakecase for this object?

		async login(ctx, credentials) {
			const HTTP = HTTPFactory()
			ctx.commit(LOADING, true, {root: true})

			// Delete an eventually preexisting old token
			removeToken()

			try {
				const response = await HTTP.post('login', objectToSnakeCase(credentials))

Why dont we simply convert credentials to snakecase for this object? ```js async login(ctx, credentials) { const HTTP = HTTPFactory() ctx.commit(LOADING, true, {root: true}) // Delete an eventually preexisting old token removeToken() try { const response = await HTTP.post('login', objectToSnakeCase(credentials)) ```

konrad commented

2022-02-06 11:39:16 +00:00

Very good point! I've changed it accordingly.

konrad marked this conversation as resolved

konrad force-pushed feature/long-tokens from e108b3a2fe to 197d5dc301

2022-02-06 11:38:51 +00:00

Compare

dpschen reviewed 2022-02-06 12:48:47 +00:00

src/store/modules/auth.js Outdated

						
				@ -1,5 +1,6 @@

				import {HTTPFactory} from '@/http-common'

				import {i18n, getCurrentLanguage, saveLanguage} from '@/i18n'

				import {objectToSnakeCase} from '../../helpers/case'