Changed green Done button to read Mark task done #1340

dmorlitz · 2022-01-08T20:54:11Z

dmorlitz commented

2022-01-08 20:54:11 +00:00

The green button can be confusing because the wording "Done" can be interpreted as "done editing the task" or "the task should be marked as done" Changing the text in the button makes the description more precise.

🎉 1 🚀 1

dmorlitz added 3 commits 2022-01-08 20:54:12 +00:00

6f5f7b190a Changed "Done!" to "Mark task done" on green button

a6e7e6efa6 Changed button test to look for "Mark task done!" - to match button change

continuous-integration/drone/pr Build is passing Details

a94198f2eb Fixed accidental change - restoring original

frederick commented

2022-01-08 20:58:41 +00:00

Hi dmorlitz!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1340-main--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dmorlitz! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1340-main--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad approved these changes 2022-01-08 21:17:34 +00:00

konrad left a comment

Thanks!

konrad merged commit 044f2b927d into main

2022-01-08 21:18:07 +00:00

konrad referenced this issue from a commit

2022-01-08 21:18:07 +00:00

feat: changed green "Done" button to read "Mark task done" (#1340)

This repo is archived. You cannot comment on pull requests.

No reviewers