vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: replace faker with community fork faker-js/faker #1408

Merged
konrad merged 1 commits from dpschen/frontend:feature/replace-faker-with-faker-js-fork into main 2022-01-20 07:54:40 +00:00
Conversation 3 Commits 1 Files Changed 12 +19 -15
dpschen commented 2022-01-19 20:19:10 +00:00
Member
Copy Link

Fixes: #1328

Fixes: https://kolaente.dev/vikunja/frontend/pulls/1328
dpschen force-pushed feature/replace-faker-with-faker-js-fork from 012ebe87ab to d9763e5379 2022-01-19 21:03:48 +00:00 Compare
frederick commented 2022-01-19 21:06:41 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://1408-featurereplace-faker-with-faker-js-fork--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://1408-featurereplace-faker-with-faker-js-fork--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad commented 2022-01-19 21:29:29 +00:00
Owner
Copy Link

Looks like the tests fail 🤔

Looks like the tests fail 🤔
dpschen commented 2022-01-19 21:30:49 +00:00
Author
Member
Copy Link

Looks like the tests fail 🤔

I guess I should also replace the imports :D

> Looks like the tests fail 🤔 I guess I should also replace the imports :D
dpschen force-pushed feature/replace-faker-with-faker-js-fork from d9763e5379 to 518c8a842d 2022-01-19 21:53:12 +00:00 Compare
konrad approved these changes 2022-01-20 07:54:25 +00:00
konrad merged commit 6db0559b81 into main 2022-01-20 07:54:40 +00:00
konrad deleted branch feature/replace-faker-with-faker-js-fork 2022-01-20 07:54:40 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#1408
No description provided.
Delete Branch "dpschen/frontend:feature/replace-faker-with-faker-js-fork"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?