feat: improve password component #1802
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#1802
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/feat-improve-password-component"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -42,3 +43,1 @@
const passwordFieldType = ref<String>('password')
const password = ref<String>('')
const isValid = ref<Boolean>(!props.validateInitially)
const passwordFieldType = ref('password')
Default ref field type is always
undefined
+ type of initial value. So no need to explicity set.Additionally if set the types should be the lower case version
string
andboolean
@ -53,4 +51,2 @@
)
function validate() {
useDebounceFn(() => {
By using the useDebounceFn this way the returned function wouldn't be reused. Which is what you want, see: https://vueuse.org/shared/usedebouncefn/
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://1802-feature-feat-improve-password-co--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
Thanks!