fix: rely on api to properly sort tasks on home page #1997
dpschen
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "fix/due-soon-first"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR changes the behaviour of how tasks are sorted. Before, the frontend would sort tasks but this resulted in some cases where tasks were not sorted properly. Most of this is test code to reliably reproduce the problem and make fixing it easier.
The actual bug was in Vikunja's api, therefore I've removed all sorting of tasks in the frontend and ensured the api properly sorts tasks.
Fixes https://github.com/go-vikunja/frontend/issues/54
Depends on vikunja/api#1177
Tests will fail since the api used in cypress tests is the old one without the fix. Will restart once the api PR is merged.
Hi konrad!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://1997-fix-due-soon-first--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
@ -0,0 +34,4 @@return {tasks, list}}import '../../support/authenticateUser'Move imports to top
Done.
@ -0,0 +106,4 @@}, false)cy.visit('/')cy.get('[data-cy="showTasks"] .card .task')Don't you remove the task class?
The
<single-task-in-list/>component still has it.I was mostly asking because I remember the task class giving styling to some childs. But if that doesnt't apply here, all good :)
WIP: fix: rely on api to properly sort tasks on home pageto fix: rely on api to properly sort tasks on home page@bolgrov This might be interesting to you.