vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix: sed replacement of SENTRY_DSN #2036

Merged
konrad merged 1 commits from k2s/frontend:k2s-SENTRY_DSN into main 2022-06-08 18:44:47 +00:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
k2s commented 2022-06-08 09:26:03 +00:00
Contributor
Copy Link

In log: vikunja-frontend-1 | sed: -e expression #1, char 46: unknown option to s'`

We need to escape the VIKUNJA_SENTRY_DSN content or change sed separator to character that will not be used in sentry DNS string which I did in this commit.

Signed-off-by: k2s martin.minka@gmail.com

In log: `vikunja-frontend-1 | sed: -e expression #1, char 46: unknown option to `s'` We need to escape the VIKUNJA_SENTRY_DSN content or change sed separator to character that will not be used in sentry DNS string which I did in this commit. Signed-off-by: k2s <martin.minka@gmail.com>
k2s added 1 commit 2022-06-08 09:26:04 +00:00
continuous-integration/drone/pr Build is passing Details
0ac3966d21 fix sed replacement of SENTRY_DSN 
In log: `vikunja-frontend-1  | sed: -e expression #1, char 46: unknown option to `s'`

We need to escape the VIKUNJA_SENTRY_DSN content or change sed separator to character that will not be used in sentry DNS string which I did in this commit.

Signed-off-by: k2s <martin.minka@gmail.com>
frederick commented 2022-06-08 09:30:09 +00:00
Member
Copy Link

Hi k2s!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2036-k2s-sentrydsn--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi k2s! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2036-k2s-sentrydsn--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad approved these changes 2022-06-08 18:44:40 +00:00
konrad left a comment
Owner

Thanks!

Thanks!
konrad merged commit d308d665bd into main 2022-06-08 18:44:47 +00:00
konrad deleted branch k2s-SENTRY_DSN 2022-06-08 18:44:47 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2036
No description provided.
Delete Branch "k2s/frontend:k2s-SENTRY_DSN"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?