vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

fix(quick add magic): time parsing for certain conditions #2367

Merged
konrad merged 1 commits from fix/quick-add-magic-time into main 2022-09-15 11:59:30 +00:00
Conversation 1 Commits 1 Files Changed 3 +64 -22
konrad commented 2022-09-15 09:52:19 +00:00
Owner
Copy Link

This PR ensures times are always recognized correctly when combined with a date. It also fixes reversing the time and date order.

Example cases which now work but didn't:

  • Something in 5 days at 10:00
  • Something 17th at 10:00
  • Something sep 17th at 10:00
  • Something at 10:00 in 5 days
  • something at 10:00 17th
  • something at 10:00 sep 17

Resolves #2349

This PR ensures times are always recognized correctly when combined with a date. It also fixes reversing the time and date order. Example cases which now work but didn't: * Something in 5 days at 10:00 * Something 17th at 10:00 * Something sep 17th at 10:00 * Something at 10:00 in 5 days * something at 10:00 17th * something at 10:00 sep 17 Resolves #2349
konrad added 1 commit 2022-09-15 09:52:20 +00:00
continuous-integration/drone/pr Build is passing Details
ea92f830fb
fix(quick add magic): time parsing for certain conditions 
Resolves #2349
konrad requested review from dpschen 2022-09-15 09:52:25 +00:00
frederick commented 2022-09-15 09:54:57 +00:00
Member
Copy Link

Hi konrad!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2367-fix-quick-add-magic-time--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi konrad! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2367-fix-quick-add-magic-time--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen reviewed 2022-09-15 11:55:13 +00:00
src/helpers/time/parseDate.ts
@ -13,3 +13,3 @@
}
export const parseDate = (text: string): dateParseResult => {
const monthsRegexGroup = '(jan|feb|mar|apr|may|jun|jul|aug|sep|oct|nov|dec)'
dpschen commented 2022-09-15 11:53:16 +00:00
Member

When reading this I realised that this could be internationalized quite easy with the help of Intl.DateTimeFormat: https://stackoverflow.com/a/66627442/15522256

When reading this I realised that this could be internationalized quite easy with the help of Intl.DateTimeFormat: https://stackoverflow.com/a/66627442/15522256
👍 1
konrad commented 2022-09-15 11:59:16 +00:00
Author
Owner

Nice catch. I bet it would have issues in Safari :D

For internationalization of the whole thing I think we'll have to translate the regexes one by one. Not sure yet how / if that's a good way but that's a problem for another day.

Nice catch. I bet it would have issues in Safari :D For internationalization of the whole thing I think we'll have to translate the regexes one by one. Not sure yet how / if that's a good way but that's a problem for another day.
dpschen commented 2022-09-15 12:08:25 +00:00
Member

Yeah I guess that the Regexes will blow up :D

Most stuff seems to be supported since Safari 14.1 though judging by https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/DateTimeFormat#browser_compatibility and https://www.stetic.com/de/market-share/browser/

Yeah I guess that the Regexes will blow up :D Most stuff seems to be supported since Safari 14.1 though judging by https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/DateTimeFormat#browser_compatibility and https://www.stetic.com/de/market-share/browser/
dpschen marked this conversation as resolved
dpschen approved these changes 2022-09-15 11:55:19 +00:00
konrad merged commit b24d5f2dce into main 2022-09-15 11:59:30 +00:00
konrad deleted branch fix/quick-add-magic-time 2022-09-15 11:59:30 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
dpschen
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2367
No description provided.
Delete Branch "fix/quick-add-magic-time"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?