vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/feat-pinia-auth-store | pinia 6/9 #2398

Merged
konrad merged 4 commits from dpschen/frontend:feature/feat-pinia-auth-store into main 2022-09-29 11:20:23 +00:00
Conversation 3 Commits 4 Files Changed 44 +349 -276
dpschen commented 2022-09-21 09:31:16 +00:00
Member
Copy Link
No description provided.
dpschen added 1 commit 2022-09-21 09:31:17 +00:00
dpschen force-pushed feature/feat-pinia-auth-store from 67ffd1094b to 0c935d4e8d 2022-09-21 10:04:21 +00:00 Compare
dpschen force-pushed feature/feat-pinia-auth-store from 0c935d4e8d to 1dc6534912 2022-09-21 10:58:00 +00:00 Compare
dpschen force-pushed feature/feat-pinia-auth-store from 1dc6534912 to 4b6c12ef2f 2022-09-21 12:12:13 +00:00 Compare
frederick commented 2022-09-21 12:15:16 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2398-feature-feat-pinia-auth-store--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2398-feature-feat-pinia-auth-store--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/feat-pinia-auth-store from 4b6c12ef2f to 10af6df364 2022-09-21 12:22:06 +00:00 Compare
dpschen added the
kind/feature
 label 2022-09-21 14:29:18 +00:00
dpschen force-pushed feature/feat-pinia-auth-store from 10af6df364 to 505501045d 2022-09-21 15:13:35 +00:00 Compare
dpschen force-pushed feature/feat-pinia-auth-store from 505501045d to e49e937ab3 2022-09-21 21:25:43 +00:00 Compare
dpschen force-pushed feature/feat-pinia-auth-store from e49e937ab3 to 03948d31c6 2022-09-21 21:32:43 +00:00 Compare
dpschen force-pushed feature/feat-pinia-auth-store from 03948d31c6 to dbb428bd7c 2022-09-22 21:33:39 +00:00 Compare
dpschen force-pushed feature/feat-pinia-auth-store from dbb428bd7c to 7718496895 2022-09-23 09:37:04 +00:00 Compare
dpschen commented 2022-09-23 09:38:32 +00:00
Author
Member
Copy Link

I didn't yet find out why this doesn't work.

I didn't yet find out why this doesn't work.
dpschen force-pushed feature/feat-pinia-auth-store from 7718496895 to 69342d4230 2022-09-23 10:58:20 +00:00 Compare
dpschen force-pushed feature/feat-pinia-auth-store from 69342d4230 to 5ce956502d 2022-09-23 11:33:19 +00:00 Compare
konrad commented 2022-09-26 11:22:18 +00:00
Owner
Copy Link

Still wip?

Still wip?
dpschen force-pushed feature/feat-pinia-auth-store from 1fde98e333 to 696206b22d 2022-09-27 21:10:38 +00:00 Compare
dpschen added the
help wanted
 label 2022-09-28 21:03:35 +00:00
dpschen force-pushed feature/feat-pinia-auth-store from f81a0edf2e to f3762fc1a6 2022-09-28 21:48:14 +00:00 Compare
dpschen force-pushed feature/feat-pinia-auth-store from bf66ea21b5 to 9f01c4e65d 2022-09-28 22:43:30 +00:00 Compare
dpschen changed title from WIP: feature/feat-pinia-auth-store | pinia 6/9 to feature/feat-pinia-auth-store | pinia 6/9 2022-09-28 22:58:49 +00:00
dpschen requested review from konrad 2022-09-28 22:58:56 +00:00
konrad was assigned by dpschen 2022-09-28 22:59:00 +00:00
dpschen removed the
help wanted
 label 2022-09-29 00:33:40 +00:00
konrad reviewed 2022-09-29 10:32:54 +00:00
src/App.vue
@ -46,2 +48,2 @@
const authUser = computed(() => store.getters['auth/authUser'])
const authLinkShare = computed(() => store.getters['auth/authLinkShare'])
const authUser = computed(() => authStore.authUser)
const authLinkShare = computed(() => authStore.authLinkShare)
konrad commented 2022-09-29 10:31:55 +00:00
Owner

Don't we need to call that function?

Don't we need to call that function?
dpschen commented 2022-09-29 10:47:43 +00:00
Author
Member

No, that would only be necessary if the getter would return a function that we want to call.

No, that would only be necessary if the getter [would return a function that we want to call](https://pinia.vuejs.org/core-concepts/getters.html#passing-arguments-to-getters).
👍 1
dpschen marked this conversation as resolved
src/components/misc/user.vue Outdated
@ -17,2 +21,2 @@
required: true,
type: Object,
type: Object as PropType<IUser>,
required: true,
konrad commented 2022-09-29 10:32:54 +00:00
Owner

Please fix the indention here.

Please fix the indention here.
👍 1
dpschen commented 2022-09-29 11:14:24 +00:00
Author
Member

Done

Done
dpschen marked this conversation as resolved
konrad reviewed 2022-09-29 10:37:39 +00:00
src/components/tasks/partials/defer-task.vue Outdated
@ -124,8 +124,10 @@ async function updateDueDate() {
}
// FIXME: direct prop manipulation
konrad commented 2022-09-29 10:34:09 +00:00
Owner

Is that still true?

Is that still true?
dpschen commented 2022-09-29 11:14:05 +00:00
Author
Member

I changed the watcher of the modelValue now so that we create a shallow copy of the task. Maybe a deep copy would be even better here.

My reasoning here is:
If the modelValue is provided by a value that is bound from store e.g. via a getter we the task would have been a direct reference to that. Now that we create a shallow copy this shouldn't be the case anymore.

I changed the watcher of the modelValue now so that we create a shallow copy of the task. Maybe a deep copy would be even better here. My reasoning here is: If the modelValue is provided by a value that is bound from store e.g. via a getter we the task would have been a direct reference to that. Now that we create a shallow copy this shouldn't be the case anymore.
👍 1
konrad commented 2022-09-29 11:17:01 +00:00
Owner

Makes sense!

Makes sense!
dpschen marked this conversation as resolved
dpschen added 1 commit 2022-09-29 11:11:28 +00:00
continuous-integration/drone/pr Build is passing Details
8e3f54ae42
feat: convert model methods to named functions
konrad approved these changes 2022-09-29 11:18:37 +00:00
konrad scheduled this pull request to auto merge when all checks succeed 2022-09-29 11:19:04 +00:00
konrad merged commit 9856fab38f into main 2022-09-29 11:20:23 +00:00
konrad deleted branch feature/feat-pinia-auth-store 2022-09-29 11:37:19 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2398
No description provided.
Delete Branch "dpschen/frontend:feature/feat-pinia-auth-store"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?