feature/feat-pinia-task-store | pinia 7/9 #2409

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2409-feature-feat-pinia-task-store--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen force-pushed feature/feat-pinia-task-store from 6f99b642e9 to 0255a44032

2022-09-28 23:26:05 +00:00

Compare

dpschen changed title from ~~WIP: feature/feat-pinia-task-store | pinia 7/9~~ to feature/feat-pinia-task-store | pinia 7/9

2022-09-29 00:33:08 +00:00

dpschen requested review from konrad 2022-09-29 00:33:14 +00:00

konrad was assigned by dpschen

2022-09-29 00:33:18 +00:00

konrad commented

2022-09-29 11:37:53 +00:00

Can you rebase this?

👍 1

dpschen added 1 commit 2022-09-29 12:03:27 +00:00

1fdda07f65

feat: move tasks to stores

dpschen commented

2022-09-29 12:05:57 +00:00

@konrad: done

konrad reviewed 2022-09-29 15:40:11 +00:00

src/components/tasks/partials/heading.vue Outdated

						
				@ -75,2 +76,3 @@

				const store = useStore()

				const loading = computed(() => store.state.loading)

				const taskStore = useTaskStore()

				const loading = computed(() => store.state.loading) // FIXME: shouldn't this reference the taskStores loading state?

konrad commented

2022-09-29 15:39:07 +00:00

It should use the task store's loading state. Mabye something like computed(() => store.state.loading || taskStore.loading)?

It should use the task store's loading state. Mabye something like `computed(() => store.state.loading || taskStore.loading)`?

dpschen commented

2022-09-29 19:38:34 +00:00

Wouldn't the taskStores loading state be enough now?

I did now only:

const loading = computed(() => taskStore.isLoading)

Wouldn't the taskStores loading state be enough now? I did now only: ```ts const loading = computed(() => taskStore.isLoading)

konrad commented

2022-09-30 11:16:11 +00:00

I think that should be fine, yes.

src/stores/tasks.ts Outdated

						
				@ -0,0 +8,4 @@

				import UserService from '@/services/user'

				import {HAS_TASKS} from '../store/mutation-types'

				import {setLoadingPinia} from '../store/helper'

konrad commented

2022-09-29 15:40:11 +00:00

Can you use @ here for the imports?

Can you use `@` here for the imports?

dpschen commented

2022-09-29 19:37:27 +00:00

I left that for 34b9b2a315 (diff-ab7455b2612e9ac43f45f7bb8a4bf872e2e6b171) since I remove the store there completely

I left that for https://kolaente.dev/vikunja/frontend/commit/34b9b2a3159ef8a5222309ba69354517d5d7690c#diff-ab7455b2612e9ac43f45f7bb8a4bf872e2e6b171 since I remove the store there completely

👍 1

dpschen marked this conversation as resolved

konrad reviewed 2022-09-29 15:41:30 +00:00

konrad left a comment

well looks like I need to always put a comment here now

😆 1

dpschen added 1 commit 2022-09-29 19:40:30 +00:00