feat: make salutation i18n static #2546

dpschen · 2022-10-16T13:31:44Z

dpschen commented

2022-10-16 13:31:44 +00:00

No description provided.

dpschen added 1 commit 2022-10-16 13:31:46 +00:00

continuous-integration/drone/pr Build is failing Details

c20de51a3c

feat: make salutation i18n static

dpschen requested review from konrad 2022-10-16 13:31:53 +00:00

konrad was assigned by dpschen

2022-10-16 13:31:56 +00:00

konrad reviewed 2022-10-16 16:33:09 +00:00

src/views/Home.vue Outdated

						
				@ -79,3 +79,3 @@

				import {useTaskStore} from '@/stores/tasks'

				const welcome = useDateTimeSalutation()

				const username = computed(() => userInfo.name !== '' ? userInfo.name : userInfo.username)

konrad commented

2022-10-16 16:33:09 +00:00

I think there's a function for this already in the user model? (Or related to it)

👍 1

dpschen commented

2022-10-16 17:38:01 +00:00

Yes! I got it now via a new getter that uses the helper you mentioned inside of the composable.

dpschen marked this conversation as resolved

konrad commented

2022-10-16 16:33:56 +00:00

Can you fix the lint issues?

👍 1

dpschen added 1 commit 2022-10-16 17:37:02 +00:00

c4d7f6fdfa

feat: get username from store getter

frederick commented

2022-10-17 00:16:14 +00:00

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2546-feature-feat-static-i18n-salutat--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2546-feature-feat-static-i18n-salutat--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen force-pushed feature/feat-static-i18n-salutation from 8094689b91 to 5afafb7c82

2022-10-17 10:35:59 +00:00

Compare

dpschen commented

2022-10-17 12:22:54 +00:00