vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: remove edit-task from list view #2721

Merged
konrad merged 1 commits from dpschen/frontend:feature/remove-edit-task-in-list-view into main 2022-11-17 15:35:21 +00:00
Conversation 1 Commits 1 Files Changed 3 +57 -317
dpschen commented 2022-11-17 12:54:03 +00:00
Member
Copy Link

the edit-task component is only used in the listview which doesn't make sense: either all views should have such quick-view mode or none. By removing this component we do remove a bit of functionality.
But: if we improve the modal of the taskdetailview it's general usability and add a new sidebar mode (instead of the current float-in-the-center we do have even a better solution

the edit-task component is only used in the listview which doesn't make sense: either all views should have such quick-view mode or none. By removing this component we _do_ remove a bit of functionality. But: if we improve the modal of the taskdetailview it's general usability and add a new sidebar mode (instead of the current float-in-the-center we do have even a better solution
dpschen added the
area/internal-code
 label 2022-11-17 12:54:03 +00:00
konrad was assigned by dpschen 2022-11-17 12:54:03 +00:00
frederick commented 2022-11-17 12:57:41 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2721-feature-remove-edit-task-in-list--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2721-feature-remove-edit-task-in-list--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/remove-edit-task-in-list-view from 53368359e1 to e7a766800d 2022-11-17 14:37:43 +00:00 Compare
konrad approved these changes 2022-11-17 15:35:06 +00:00
konrad left a comment
Owner

I've actually been wanting to do this, very nice!

I've actually been wanting to do this, very nice!
konrad merged commit 45ec1623d5 into main 2022-11-17 15:35:21 +00:00
konrad deleted branch feature/remove-edit-task-in-list-view 2022-11-17 15:35:21 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2721
No description provided.
Delete Branch "dpschen/frontend:feature/remove-edit-task-in-list-view"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?