feat: move update from navigation to app #2997
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#2997
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/move-update-to-app"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://2997-feature-move-update-to-app--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
Any way to test this?
I guess you refer mostly to the changes in
Update.vue
, right?You can build a version then serve it locally via https-localhost.
Open the app and let the service worker load the stuff.
Rebuild the app with a mini change and serve it again. The update should appear.
Looks like the update notice is a) only visible when not logged in and b) even there not fully:
Fixed the z-index on the banner so that now it stays on top at all times.
I'm confused that the the dark version works without using
:global()
since the style is scoped and thedark
class is neither set from inside nor on the element itself.It actually does not work at all with the
:global()
helper. The generated class looks like this without it:.dark .update-notification[data-v-4c295d9f]
- the scoped data-attribute is only applied to the.update-notification
class. With the:global()
helper it compiles to.dark
only.This might be a bug in the helper but I'd say we can leave it like this for now.
Seems like a bug: https://vuejs.org/api/sfc-css-features.html#global-selectors
@ -1,5 +1,6 @@
<template>
<ready>
<Update/>
If we move
<Update>
below<Notification>
can we then remove the z-index?.We might want to move
<KeyboardShortcuts>
above<Notification>
at the same time. I'm unsure but couldn't the current order make the Shortcuts appear above the Notifications?That seems to work on the login page but does not in the rest of Vikunja. Let's leave it with the z-index.
Not sure, I checked it and it seems to work fine like it is now.
28fad65d9d
to058cfe1318
058cfe1318
toeaeddda4e4
I found out why the dark styles were broken. I think I found out why we had those bulma-css-variable problems…
But not in this pull request.