Refactored IPv6 control script #3058

vlasov-y · 2023-02-04T07:40:34Z

vlasov-y commented

2023-02-04 07:40:34 +00:00

Hi @konrad!

Sorry, that I did not reply to IPv6 issue on time. I have based on GitHub PR making this refactoring.

Changes

Removed default nginx IPv6 control script because it does not work (as was already mentioned by RoboMagus in the GitHub issue)
Chanted the script to search all configs without hardcoded path
Added verbosity showing the diff during the runtime (check the screenshot), so that the script shows exactly what has changed for every config file it finds (maybe we will have more in future)
Whitespace change in the config (in front of the comment

Hi @konrad! Sorry, that I did not reply to [IPv6 issue](https://github.com/go-vikunja/frontend/issues/101) on time. I have based on [GitHub PR](https://github.com/go-vikunja/frontend/pull/102) making this refactoring. **Changes** 1. Removed default nginx IPv6 control script because it does not work (as was already mentioned by RoboMagus in the GitHub issue) 2. Chanted the script to search all configs without hardcoded path 3. Added verbosity showing the diff during the runtime (check the screenshot), so that the script shows exactly what has changed for every config file it finds (maybe we will have more in future) 4. Whitespace change in the config (in front of the comment ![image](/attachments/5ff7d053-176c-4fc6-9bf3-c778166ca11b)

image.png

63 KiB

vlasov-y added 1 commit 2023-02-04 07:40:36 +00:00

continuous-integration/drone/pr Build is passing Details

5ac1b5919a Added ipv6 control script

vlasov-y changed title from ~~Added ipv6 control script~~ to Refactored IPv6 control script

2023-02-04 07:40:45 +00:00

frederick commented

2023-02-04 07:45:42 +00:00

Hi vlasov-y!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3058-main--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi vlasov-y! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3058-main--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad was assigned by dpschen

2023-02-07 12:40:35 +00:00

dpschen requested review from konrad 2023-02-07 12:40:38 +00:00

dpschen added the

kind/bug

label 2023-02-07 12:40:45 +00:00

konrad approved these changes 2023-02-09 21:43:29 +00:00

konrad left a comment

Looks good, don't have a non-ipv6 host to test this on though. I think it's still fine to merge as it can only get better for ipv4-only hosts.

Thanks!

Looks good, don't have a non-ipv6 host to test this on though. I think it's still fine to merge as it can only get better for ipv4-only hosts. Thanks!

🎉 1

konrad merged commit 3f4b08b8be into main

2023-02-09 21:43:34 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers