vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

refactor: improve stores/config types #3190

Merged
konrad merged 2 commits from WofWca/frontend:refactor into main 2023-03-03 14:37:01 +00:00
Conversation 1 Commits 2 Files Changed 3 +5 -4
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0954984792 - Show all commits

4
src/helpers/checkAndSetApiUrl.ts
View File

@ -113,8 +113,8 @@ export const checkAndSetApiUrl = (url: string): Promise<string> => {
window.API_URL = oldUrl
throw e
})
.then(r => {
if (typeof r !== 'undefined') {
.then(success => {
if (success) {
localStorage.setItem('API_URL', window.API_URL)
return window.API_URL
}

5
src/stores/config.ts
View File

@ -79,11 +79,12 @@ export const useConfigStore = defineStore('config', () => {
function setConfig(config: ConfigState) {
Object.assign(state, config)
}
async function update() {
async function update(): Promise<boolean> {
const HTTP = HTTPFactory()
const {data: config} = await HTTP.get('info')
setConfig(objectToCamelCase(config))
return config
const success = !!config
return success
konrad marked this conversation as resolved
konrad commented 2023-03-03 14:11:32 +00:00
Review
Copy Link

Why not Boolean(config)? Or something like Object.keys(config).length > 0?

Why not `Boolean(config)`? Or something like `Object.keys(config).length > 0`?
WofWca commented 2023-03-03 14:18:33 +00:00
Review
Copy Link

No particular reason. I'm just used to !!, and I tried to keep the logic the same.

No particular reason. I'm just used to `!!`, and I tried to keep the logic the same.
konrad commented 2023-03-03 14:23:49 +00:00
Review
Copy Link

Fair enough.

Fair enough.
}
return {