fix: improve the "pop" sound a bit #3293

WofWca · 2023-03-23T19:40:47Z

WofWca commented

2023-03-23 19:40:47 +00:00

Trim the (noisy) silence (especially at the start, because
that delay from making a change and playing a sound is a little
annoying), with fade-in and fade-out

Edited with Audacity

File(s) history:
7f5140bbb4
955bd73fec

Before:

After:

I'm not sure what's the point of having 3 separate copies, but I rewrote them all.

Trim the (noisy) silence (especially at the start, because that delay from making a change and playing a sound is a little annoying), with fade-in and fade-out Edited with Audacity File(s) history: 7f5140bbb418f4a5b6252f8b62c9152ef3f657f3 955bd73feccefe8e8ca54d946d6223b43a0836ed Before: ![image](/attachments/01df05e3-000d-4bce-b8c4-279015aa8f72) After: ![image](/attachments/4b5005f3-a3f9-4847-8ccc-140068b49b8b) I'm not sure what's the point of having 3 separate copies, but I rewrote them all.

image.png

5.5 KiB

image.png

5.3 KiB

WofWca added 1 commit 2023-03-23 19:40:49 +00:00

continuous-integration/drone/pr Build is passing Details

continuous-integration/drone/push Build is passing Details

3643ffe0d0 fix: improve the "pop" sound a bit

Trim the (noisy) silence (especially at the start, because
that delay from making a change and playing a sound is a little
annoying), with fade-in and fade-out

Edited with Audacity

File(s) history:
7f5140bbb4
955bd73fec

frederick commented

2023-03-23 19:45:44 +00:00

Hi WofWca!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3293-improve-pop-sound--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi WofWca! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3293-improve-pop-sound--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad commented

2023-03-23 20:04:05 +00:00

IIRC we need the different copies to support the different browsers.
Not sure about the files in originalMedia, @dpschen didn't you create those?

IIRC we need the different copies to support the different browsers. Not sure about the files in originalMedia, @dpschen didn't you create those?

konrad merged commit 3643ffe0d0 into main

2023-03-23 20:05:02 +00:00

konrad deleted branch improve-pop-sound

2023-03-23 20:05:03 +00:00

dpschen commented

2023-03-23 21:34:26 +00:00

Unsure why there was an mo3 in the originalMedia folder. What the latter is for is written in the commit message of the linked commit - those are supposed to be the originals. We should probably include that somewhere in the docs or at least in some README file in the repo.

So to reduce quality loss the corrwct way would have been to adjust the wav and then create the mp3s based on that.

Unsure why there was an mo3 in the originalMedia folder. What the latter is for is written in the commit message of the linked commit - those are supposed to be the originals. We should probably include that somewhere in the docs or at least in some README file in the repo. So to reduce quality loss the corrwct way would have been to adjust the wav and then create the mp3s based on that.

WofWca commented

2023-03-24 06:56:12 +00:00