vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Fix allow icon changes #3567

Merged
konrad merged 1 commits from steffeydev/vikunja-frontend:fix-icon-disable-change into main 2023-06-05 14:19:58 +00:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
steffeydev commented 2023-06-04 21:02:52 +00:00
Contributor
Copy Link

window.ALLOW_ICON_CHANGES needs to be written as a boolean during the docker deploy instead of a string. The strings "true" and "false" both evaluate to true in JS, so we need to use the boolean true and false for the assertion in Logo.vue to be meaningful.

`window.ALLOW_ICON_CHANGES` needs to be written as a boolean during the docker deploy instead of a string. The strings `"true"` and `"false"` both evaluate to `true` in JS, so we need to use the boolean `true` and `false` for the assertion in `Logo.vue` to be meaningful.
steffeydev added 1 commit 2023-06-04 21:02:54 +00:00
continuous-integration/drone/pr Build is passing Details
871335c53e Fix allow icon changes
frederick commented 2023-06-04 21:07:00 +00:00
Member
Copy Link

Hi steffeydev!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3567-fix-icon-disable-change--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi steffeydev! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3567-fix-icon-disable-change--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad approved these changes 2023-06-05 14:19:30 +00:00
konrad left a comment
Owner

Thanks!

Thanks!
konrad merged commit 57218d1454 into main 2023-06-05 14:19:57 +00:00
konrad deleted branch fix-icon-disable-change 2023-06-05 14:19:58 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#3567
No description provided.
Delete Branch "steffeydev/vikunja-frontend:fix-icon-disable-change"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?