Show an icon if a task has non-empty description (Kanban view and List view) #360

profi248 · 2020-12-30T12:25:37Z

profi248 commented

2020-12-30 12:25:37 +00:00

Add an icon to indicate that task has a description (similar to Trello). Would also be nice to add a counter for comments, but it's not possible to reasonably currently implement unless the API also gets changed.

Also add attachment icon to List view, and change the icon in Kanban view to be consistent with the rest of the icon set.

Add an icon to indicate that task has a description (similar to Trello). Would also be nice to add a counter for comments, but it's not possible to reasonably currently implement unless the API also gets changed. Also add attachment icon to List view, and change the icon in Kanban view to be consistent with the rest of the icon set. ![image](/attachments/f88c4736-4cab-4a3e-80eb-657deb5223ad) ![image](/attachments/2c524c7a-c3b5-412d-8724-8111fba2a6b3)

image.png

49 KiB

image.png

63 KiB

image.png

35 KiB

konrad approved these changes 2020-12-30 16:49:22 +00:00

konrad left a comment

Looking good, thanks!

Could you add more spacing between the icons in the list view? The kanban view looks fine.

Looking good, thanks! Could you add more spacing between the icons in the list view? The kanban view looks fine.

src/styles/components/kanban.scss Outdated

						
				@ -123,0 +123,4 @@

				          .icons-container {

				            display: flex;

				            .icon {

				              width: 25px;

konrad commented

2020-12-30 16:48:19 +00:00

Where's that number coming from? And why is it 25px width but only 25px heigh?

profi248 commented

2020-12-30 18:44:51 +00:00

It's from the existing paperclip icon, it had exactly those dimensions. I copied it so it would match the exact size.

konrad commented

2020-12-30 19:51:44 +00:00

I see, thanks for the explanation. The height does not seem to make a difference, the rest is derived from the font size. The width only has an effect on the padding so I think it should have padding to make that clear. Could you add something like padding: 0 .25rem; and remove the width and height?

I see, thanks for the explanation. The height does not seem to make a difference, the rest is derived from the font size. The width only has an effect on the padding so I think it should have padding to make that clear. Could you add something like `padding: 0 .25rem;` and remove the `width` and `height`?

profi248 commented

2020-12-30 21:01:26 +00:00

Okay, it's changed to padding now