vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Show an icon if a task has non-empty description (Kanban view and List view) #360

Merged
konrad merged 4 commits from profi248/frontend:description-indicator into master 2020-12-30 21:20:33 +00:00
Conversation 1 Commits 4 Files Changed 4 +4 -2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4167352659 - Show all commits

6
src/styles/components/kanban.scss
View File

@ -125,11 +125,13 @@ $crazy-height-calculation: '100vh - 4.5rem - 1.5rem - 1em - 1.5em - 8px';
display: flex;
align-items: flex-end;
konrad commented 2020-12-30 16:48:19 +00:00
Outdated
Review
Copy Link

Where's that number coming from? And why is it 25px width but only 25px heigh?

Where's that number coming from? And why is it 25px width but only 25px heigh?
profi248 commented 2020-12-30 18:44:51 +00:00
Outdated
Review
Copy Link

It's from the existing paperclip icon, it had exactly those dimensions. I copied it so it would match the exact size.

It's from the existing paperclip icon, it had exactly those dimensions. I copied it so it would match the exact size.
konrad commented 2020-12-30 19:51:44 +00:00
Outdated
Review
Copy Link

I see, thanks for the explanation. The height does not seem to make a difference, the rest is derived from the font size. The width only has an effect on the padding so I think it should have padding to make that clear. Could you add something like padding: 0 .25rem; and remove the width and height?

I see, thanks for the explanation. The height does not seem to make a difference, the rest is derived from the font size. The width only has an effect on the padding so I think it should have padding to make that clear. Could you add something like `padding: 0 .25rem;` and remove the `width` and `height`?
profi248 commented 2020-12-30 21:01:26 +00:00
Outdated
Review
Copy Link

Okay, it's changed to padding now

Okay, it's changed to padding now
.icon {
width: 25px;
height: 24px;
padding: 0px .4rem;
&:not(:first-child) {
margin-left: 4px;
}
svg {
margin: 0;
}
}
}