vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Allow custom logo via environment variable #3685

Merged
konrad merged 6 commits from davidangel/frontend:allow-custom-logo into main 2023-08-23 16:13:31 +00:00
Conversation 2 Commits 6 Files Changed 5 +13 -2
davidangel commented 2023-07-15 04:35:07 +00:00
Contributor
Copy Link

Allows for custom logo via URL configured in an environment variable.

Discussed a bit here: https://community.vikunja.io/t/change-vikunja-logo-and-color-scheme/621

I don't have any Go experience, or it might be tempting to create upload/settings configuration for this sort of thing. I think this may scratch the itch that some of us have for using our own logo in the meantime.

Allows for custom logo via URL configured in an environment variable. <img src="/attachments/75a71036-c857-4acf-a629-582bb4e96c55" height="200" /> Discussed a bit here: https://community.vikunja.io/t/change-vikunja-logo-and-color-scheme/621 I don't have any Go experience, or it might be tempting to create upload/settings configuration for this sort of thing. I think this may scratch the itch that some of us have for using our own logo in the meantime.
image.png
31 KiB
davidangel added 3 commits 2023-07-15 04:35:09 +00:00 
Reviewed-on: davidangel/frontend#1
Allow custom logo via ENV variable
All checks were successful
continuous-integration/drone/pr Build is passing
Details
48117039c0
frederick commented 2023-07-15 04:42:37 +00:00
Member
Copy Link

Hi davidangel!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3685-allow-custom-logo--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi davidangel! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3685-allow-custom-logo--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2023-07-16 04:31:08 +00:00
konrad left a comment
Owner

Looks not bad, will take a proper look and test it when I get back from my vacation.

Looks not bad, will take a proper look and test it when I get back from my vacation.
index.html Outdated
@ -32,3 +32,3 @@
window.PROJECT_INFINITE_NESTING_ENABLED = false
// Allow changing the logo and other icons based on various occasions throughout the year.
window.ALLOW_ICON_CHANGES = true
window.ALLOW_ICON_CHANGES = false
konrad commented 2023-07-16 04:29:25 +00:00
Owner

This should stay on true by default.

This should stay on true by default.
👍 1
davidangel marked this conversation as resolved
davidangel added 1 commit 2023-07-16 10:58:19 +00:00
Revert unintentional change
All checks were successful
continuous-integration/drone/pr Build is passing
Details
71d811064f
davidangel added 1 commit 2023-07-16 11:00:04 +00:00
Merge branch 'main' into allow-custom-logo
All checks were successful
continuous-integration/drone/pr Build is passing
Details
f0af4c6547
konrad approved these changes 2023-08-23 15:58:56 +00:00
konrad added 1 commit 2023-08-23 15:59:09 +00:00
Merge branch 'main' into allow-custom-logo
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7453b7472d
konrad merged commit cade3df3e9 into main 2023-08-23 16:13:31 +00:00
konrad deleted branch allow-custom-logo 2023-08-23 16:13:31 +00:00
konrad commented 2023-08-23 16:13:37 +00:00
Owner
Copy Link

Thanks!

Thanks!
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
konrad
Labels
Clear labels
area/internal-code
changes requested
confirmed
dependencies
duplicate
This issue or pull request already exists
good first issue
help wanted
Need some help
hosting
invalid
Something is wrong
kind/bug
Something is not working
kind/feature
New feature
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: vikunja/frontend#3685
No description provided.
Delete Branch "davidangel/frontend:allow-custom-logo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?