Allow custom logo via environment variable #3685

Merged
konrad merged 6 commits from davidangel/frontend:allow-custom-logo into main 2023-08-23 16:13:31 +00:00
Contributor

Allows for custom logo via URL configured in an environment variable.

Discussed a bit here: https://community.vikunja.io/t/change-vikunja-logo-and-color-scheme/621

I don't have any Go experience, or it might be tempting to create upload/settings configuration for this sort of thing. I think this may scratch the itch that some of us have for using our own logo in the meantime.

Allows for custom logo via URL configured in an environment variable. <img src="/attachments/75a71036-c857-4acf-a629-582bb4e96c55" height="200" /> Discussed a bit here: https://community.vikunja.io/t/change-vikunja-logo-and-color-scheme/621 I don't have any Go experience, or it might be tempting to create upload/settings configuration for this sort of thing. I think this may scratch the itch that some of us have for using our own logo in the meantime.
davidangel added 3 commits 2023-07-15 04:35:09 +00:00
Member

Hi davidangel!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3685-allow-custom-logo--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi davidangel! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3685-allow-custom-logo--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2023-07-16 04:31:08 +00:00
konrad left a comment
Owner

Looks not bad, will take a proper look and test it when I get back from my vacation.

Looks not bad, will take a proper look and test it when I get back from my vacation.
index.html Outdated
@ -32,3 +32,3 @@
window.PROJECT_INFINITE_NESTING_ENABLED = false
// Allow changing the logo and other icons based on various occasions throughout the year.
window.ALLOW_ICON_CHANGES = true
window.ALLOW_ICON_CHANGES = false

This should stay on true by default.

This should stay on true by default.
davidangel marked this conversation as resolved
davidangel added 1 commit 2023-07-16 10:58:19 +00:00
continuous-integration/drone/pr Build is passing Details
71d811064f
Revert unintentional change
davidangel added 1 commit 2023-07-16 11:00:04 +00:00
continuous-integration/drone/pr Build is passing Details
f0af4c6547
Merge branch 'main' into allow-custom-logo
konrad approved these changes 2023-08-23 15:58:56 +00:00
konrad added 1 commit 2023-08-23 15:59:09 +00:00
continuous-integration/drone/pr Build is passing Details
7453b7472d
Merge branch 'main' into allow-custom-logo
konrad merged commit cade3df3e9 into main 2023-08-23 16:13:31 +00:00
konrad deleted branch allow-custom-logo 2023-08-23 16:13:31 +00:00
Owner

Thanks!

Thanks!
This repo is archived. You cannot comment on pull requests.
No description provided.