chore: discard old font file formats #673

dpschen · 2021-08-23T16:28:02Z

dpschen commented

2021-08-23 16:28:02 +00:00

browser support for woff2 is 96%; see: https://caniuse.com/woff2

konrad commented

2021-08-23 16:36:27 +00:00

Does this really make a difference? AFAIU browsers will only load the formats they understand so if a browser knows how to use woff2 it will ignore the other formats.
Maybe it's a good idea to keep at least woff?

Does this really make a difference? AFAIU browsers will only load the formats they understand so if a browser knows how to use woff2 it will ignore the other formats. Maybe it's a good idea to keep at least woff?

dpschen commented

2021-08-23 16:56:28 +00:00

See: https://stackoverflow.com/questions/11002820/why-should-we-include-ttf-eot-woff-svg-in-a-font-face
So woff makes just sense if you support IE11?
But it makes sense to also remove the local includes: https://stackoverflow.com/a/36110385/15522256
I will change the pull request accordingly.

See: https://stackoverflow.com/questions/11002820/why-should-we-include-ttf-eot-woff-svg-in-a-font-face So woff makes just sense if you support IE11? But it makes sense to also remove the `local` includes: https://stackoverflow.com/a/36110385/15522256 I will change the pull request accordingly.

dpschen force-pushed feature/only-woff2-fonts from 22791ee9f2 to efecfb1e26

2021-08-23 17:00:03 +00:00

Compare

konrad commented

2021-08-23 17:00:59 +00:00

Yeah I think that makes sense. We don't support IE since it is officially discontinued by Microsoft.

I was more worried about older version of Firefox and co, but then the question is how much Vikunja works in those and if a broken font would be the biggest issue (I don't think so). Maybe we can just remove woff and add it back in when someone complains?

Yeah I think that makes sense. We don't support IE since it is officially discontinued by Microsoft. I was more worried about older version of Firefox and co, but then the question is how much Vikunja works in those and if a broken font would be the biggest issue (I don't think so). Maybe we can just remove woff and add it back in when someone complains?

dpschen commented

2021-08-23 17:23:21 +00:00

That makes sense! :)

I wouldn't assume it will be a problem. Firefox doesn't have many user and it's evergreen, so I wouldn't assume problems there =)

I have used only woff2 in larger projects and nobody complained :D

That makes sense! :) I wouldn't assume it will be a problem. Firefox doesn't have many user and it's evergreen, so I wouldn't assume problems there =) I have used only woff2 in larger projects and nobody complained :D

konrad approved these changes 2021-08-23 17:42:25 +00:00

konrad left a comment

Thanks again!

konrad merged commit 19f52eb8d1 into main

2021-08-23 17:42:31 +00:00

konrad referenced this issue from a commit

2021-08-23 17:42:32 +00:00

chore: discard old font file formats (#673)

dpschen deleted branch feature/only-woff2-fonts

2021-08-23 18:39:45 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers